Skip to content

Widen the columns for the metric width tables #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
Apr 29, 2026
Merged

Widen the columns for the metric width tables #4202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flow/util/genRuleFile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def gen_rule_file(
"[WARNING] 'constraints__clocks__details' not found or is empty in metrics. Clock-related rules might be affected."
)

format_str = "| {:45} | {:8} | {:8} | {:8} |\n"
format_str = "| {:45} | {:10} | {:10} | {:8} |\n"

@gemini-code-assist gemini-code-assist Bot Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current format string uses default alignment, which differs between strings (left-aligned) and numbers (right-aligned). This causes the headers ("Old", "New") to be misaligned with the numeric values in the table. Adding explicit right-alignment ({:>12}) ensures that both headers and numeric data are consistently aligned.

Additionally, while 10 characters accommodate the example value, Total Negative Slack (TNS) values in larger designs can easily exceed this width (e.g., -10000000.0 is 11 characters). Using a width of 12 provides better coverage for such cases.

Suggested change
format_str = "| {:45} | {:10} | {:10} | {:8} |\n"
format_str = "| {:<45} | {:>12} | {:>12} | {:<8} |\n"

change_str = ""

processed_fields = set()
Expand Down