flow: pass CTS_DPL_DISPLACEMENT to post-CTS detailed_placement#4245
Closed
oharboe wants to merge 1 commit into
Closed
flow: pass CTS_DPL_DISPLACEMENT to post-CTS detailed_placement#4245oharboe wants to merge 1 commit into
oharboe wants to merge 1 commit into
Conversation
Seed `dpl_args` from `env_var_or_empty CTS_DPL_DISPLACEMENT` instead
of the empty list, so callers can pass extra flags (typically
`-max_displacement <row> <site>`) to the detailed_placement run
immediately after CTS without having to fork the script.
When the env var is unset, `env_var_or_empty` returns "" and the
`{*}$dpl_args` expansion is a no-op — behavior matches the prior
`{}` initialization exactly.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the flow/scripts/cts.tcl script to initialize detailed placement arguments using the CTS_DPL_DISPLACEMENT environment variable, allowing for configurable displacement during Clock Tree Synthesis. I have no feedback to provide as no review comments were submitted.
Collaborator
Author
|
too specialized for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpl_argsinflow/scripts/cts.tclfromenv_var_or_empty CTS_DPL_DISPLACEMENTinstead of the empty list, so the post-CTSdetailed_placementcall can receive extra flags (e.g.-max_displacement <row> <site>) via env var instead of needing a forked script.CTS_DPL_DISPLACEMENTis unset,env_var_or_emptyreturns""and{*}$dpl_argsexpands to nothing — fully backward compatible with the previous{}initialization.Test plan
CTS_DPL_DISPLACEMENTunset, post-CTS detailed_placement behaves identically (no flag added).CTS_DPL_DISPLACEMENT="-max_displacement 5 5", the flag reachesdetailed_placement.