Add readline to the dependency installer for yosys#4246
Merged
maliberty merged 1 commit intoMay 20, 2026
Merged
Conversation
It was previously getting it from the OpenROAD dependency installer but that was removed. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds readline dependencies to the DependencyInstaller.sh script for EL7, EL8/EL9, and Ubuntu. The reviewer suggests using the development package readline-devel instead of the runtime package readline for the Enterprise Linux distributions to ensure the necessary header files are available for compilation.
Member
Author
|
yosys built so merge, any remaining issues are unrelated. |
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was previously getting it from the OpenROAD dependency installer but that was removed.