Skip to content

add variable to enable repair_timing post global placement #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eder-matheus merged 12 commits into from
Jun 11, 2026
Merged

add variable to enable repair_timing post global placement #4252

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5d53427
add ENABLE_PLACE_REPAIR_TIMING var to enable post-gpl repair_timing
eder-matheus May 21, 2026
2aadc2a
remove post-dpl repair timing target
eder-matheus May 21, 2026
382eaed
add missing set_dont_use call
eder-matheus May 21, 2026
f2d71aa
use latest openroad
eder-matheus May 22, 2026
492b06e
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
eder-matheus May 26, 2026
6b73e3c
bump or
eder-matheus May 26, 2026
0de8415
use latest openroad
eder-matheus May 26, 2026
1931dc7
flow: update rules
github-actions[bot] May 26, 2026
5dafa97
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
eder-matheus May 28, 2026
8da7a93
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
eder-matheus Jun 2, 2026
cc84c44
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
eder-matheus Jun 10, 2026
286e15e
flow: update rules
github-actions[bot] Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions docs/user/FlowVariables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ configuration file.
| <a name="DPO_MAX_DISPLACEMENT"></a>DPO_MAX_DISPLACEMENT| Specifies how far an instance can be moved when optimizing.| 5 1|
| <a name="EARLY_SIZING_CAP_RATIO"></a>EARLY_SIZING_CAP_RATIO| Ratio between the input pin capacitance and the output pin load during initial gate sizing.| |
| <a name="ENABLE_DPO"></a>ENABLE_DPO| Enable detail placement with improve_placement feature.| 1|
| <a name="ENABLE_PLACE_REPAIR_TIMING"></a>ENABLE_PLACE_REPAIR_TIMING| Run repair_timing during the placement resize stage using placement parasitics. Disabled by default; pre-CTS setup/hold repair is skipped unless this is set to 1.| 0|
| <a name="ENABLE_RESISTANCE_AWARE"></a>ENABLE_RESISTANCE_AWARE| Passed as -resistance_aware to global_route.| |
| <a name="FASTROUTE_TCL"></a>FASTROUTE_TCL| Specifies a Tcl script with commands to run before FastRoute.| |
| <a name="FILL_CELLS"></a>FILL_CELLS| Fill cells are used to fill empty sites. If not set or empty, fill cell insertion is skipped.| |
Expand Down Expand Up @@ -216,7 +217,6 @@ configuration file.
| <a name="POST_IO_PLACEMENT_TCL"></a>POST_IO_PLACEMENT_TCL| Specifies a Tcl script with commands to run after IO placement.| |
| <a name="POST_MACRO_PLACE_TCL"></a>POST_MACRO_PLACE_TCL| Specifies a Tcl script with commands to run after macro placement.| |
| <a name="POST_PDN_TCL"></a>POST_PDN_TCL| Specifies a Tcl script with commands to run after PDN generation.| |
| <a name="POST_REPAIR_TIMING_POST_PLACE_TCL"></a>POST_REPAIR_TIMING_POST_PLACE_TCL| Specifies a Tcl script with commands to run after post-place timing repair.| |
| <a name="POST_RESIZE_TCL"></a>POST_RESIZE_TCL| Specifies a Tcl script with commands to run after resize.| |
| <a name="POST_SYNTH_TCL"></a>POST_SYNTH_TCL| Specifies a Tcl script with commands to run after synthesis ODB generation.| |
| <a name="POST_TAPCELL_TCL"></a>POST_TAPCELL_TCL| Specifies a Tcl script with commands to run after tapcell.| |
Expand All @@ -233,7 +233,6 @@ configuration file.
| <a name="PRE_IO_PLACEMENT_TCL"></a>PRE_IO_PLACEMENT_TCL| Specifies a Tcl script with commands to run before IO placement.| |
| <a name="PRE_MACRO_PLACE_TCL"></a>PRE_MACRO_PLACE_TCL| Specifies a Tcl script with commands to run before macro placement.| |
| <a name="PRE_PDN_TCL"></a>PRE_PDN_TCL| Specifies a Tcl script with commands to run before PDN generation.| |
| <a name="PRE_REPAIR_TIMING_POST_PLACE_TCL"></a>PRE_REPAIR_TIMING_POST_PLACE_TCL| Specifies a Tcl script with commands to run before post-place timing repair.| |
| <a name="PRE_RESIZE_TCL"></a>PRE_RESIZE_TCL| Specifies a Tcl script with commands to run before resize.| |
| <a name="PRE_SYNTH_TCL"></a>PRE_SYNTH_TCL| Specifies a Tcl script with commands to run before synthesis ODB generation.| |
| <a name="PRE_TAPCELL_TCL"></a>PRE_TAPCELL_TCL| Specifies a Tcl script with commands to run before tapcell.| |
Expand Down Expand Up @@ -465,6 +464,7 @@ configuration file.
- [DETAIL_PLACEMENT_ARGS](#DETAIL_PLACEMENT_ARGS)
- [DONT_BUFFER_PORTS](#DONT_BUFFER_PORTS)
- [EARLY_SIZING_CAP_RATIO](#EARLY_SIZING_CAP_RATIO)
- [ENABLE_PLACE_REPAIR_TIMING](#ENABLE_PLACE_REPAIR_TIMING)
- [FLOORPLAN_DEF](#FLOORPLAN_DEF)
- [GLOBAL_PLACEMENT_ARGS](#GLOBAL_PLACEMENT_ARGS)
- [GPL_KEEP_OVERFLOW](#GPL_KEEP_OVERFLOW)
Expand All @@ -485,13 +485,11 @@ configuration file.
- [POST_GLOBAL_PLACE_SKIP_IO_TCL](#POST_GLOBAL_PLACE_SKIP_IO_TCL)
- [POST_GLOBAL_PLACE_TCL](#POST_GLOBAL_PLACE_TCL)
- [POST_IO_PLACEMENT_TCL](#POST_IO_PLACEMENT_TCL)
- [POST_REPAIR_TIMING_POST_PLACE_TCL](#POST_REPAIR_TIMING_POST_PLACE_TCL)
- [POST_RESIZE_TCL](#POST_RESIZE_TCL)
- [PRE_DETAIL_PLACE_TCL](#PRE_DETAIL_PLACE_TCL)
- [PRE_GLOBAL_PLACE_SKIP_IO_TCL](#PRE_GLOBAL_PLACE_SKIP_IO_TCL)
- [PRE_GLOBAL_PLACE_TCL](#PRE_GLOBAL_PLACE_TCL)
- [PRE_IO_PLACEMENT_TCL](#PRE_IO_PLACEMENT_TCL)
- [PRE_REPAIR_TIMING_POST_PLACE_TCL](#PRE_REPAIR_TIMING_POST_PLACE_TCL)
- [PRE_RESIZE_TCL](#PRE_RESIZE_TCL)
- [ROUTING_LAYER_ADJUSTMENT](#ROUTING_LAYER_ADJUSTMENT)
- [SKIP_REPORT_METRICS](#SKIP_REPORT_METRICS)
Expand Down
6 changes: 0 additions & 6 deletions flow/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,12 +479,6 @@ $(eval $(call do-copy,3_place,2_floorplan.sdc,,.sdc))
do-place:
$(UNSET_AND_MAKE) do-3_1_place_gp_skip_io do-3_2_place_iop do-3_3_place_gp do-3_4_place_resized do-3_5_place_dp do-3_place do-3_place.sdc

# Custom repair_timing target after placement
$(eval $(call do-step,3_6_place_repair_timing,$(RESULTS_DIR)/3_5_place_dp.odb $(RESULTS_DIR)/3_place.sdc,repair_timing_post_place))

.PHONY: place_repair_timing
place_repair_timing: $(RESULTS_DIR)/3_6_place_repair_timing.odb

# Clean Targets
#-------------------------------------------------------------------------------
.PHONY: clean_place
Expand Down
1 change: 1 addition & 0 deletions flow/scripts/floorplan.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ if { [env_var_exists_and_non_empty FASTROUTE_TCL] } {
}

source_env_var_if_exists FOOTPRINT_TCL
set_dont_use $::env(DONT_USE_CELLS)

# The transforms below (repair_tie_fanout, replace_arith_modules,
# remove_buffers, repair_timing_helper) look like synthesis-stage
Expand Down
3 changes: 0 additions & 3 deletions flow/scripts/floorplan_to_place.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,3 @@ source $::env(SCRIPTS_DIR)/resize.tcl

# Detailed placement
source $::env(SCRIPTS_DIR)/detail_place.tcl

# Repair timing after placement
source $::env(SCRIPTS_DIR)/repair_timing_post_place.tcl
24 changes: 0 additions & 24 deletions flow/scripts/repair_timing_post_place.tcl
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion flow/scripts/resize.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ if { [env_var_exists_and_non_empty SWAP_ARITH_OPERATORS] } {

repair_design_helper

# hold violations are not repaired until after CTS
if { $::env(ENABLE_PLACE_REPAIR_TIMING) } {
# Repair timing using placement parasitics.
puts "Repair setup and hold violations..."
log_cmd estimate_parasitics -placement

repair_timing_helper
}
Comment on lines +27 to +33

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment and the puts message indicate that both setup and hold violations are being repaired. However, the underlying repair_timing command (which repair_timing_helper wraps) defaults to fixing only setup violations unless the -hold flag is explicitly provided. Additionally, repairing hold violations pre-CTS (with an ideal clock) is generally discouraged as it can lead to excessive buffering based on inaccurate timing.

If only setup repair is intended, it is better to be explicit and update the messages for clarity. If hold repair was truly intended, the appropriate flags should be passed to the helper, though this should be done with caution at this stage of the flow.

if { $::env(ENABLE_PLACE_REPAIR_TIMING) } {
  # Repair timing using placement parasitics.
  puts "Repair setup violations..."
  log_cmd estimate_parasitics -placement

  repair_timing_helper -setup
}

@eder-matheus eder-matheus May 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first part of this review is incorrect: repair_timing_helper fixes hold violations even without the -hold flag.

However, the second point is interesting. @precisionmoon do you think we should skip hold fixes at this stage?


# post report

Expand Down
19 changes: 7 additions & 12 deletions flow/scripts/variables.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 8 additions & 10 deletions flow/scripts/variables.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,14 @@ SKIP_CTS_REPAIR_TIMING:
stages:
- cts
default: 0
ENABLE_PLACE_REPAIR_TIMING:
description: >
Run repair_timing during the placement resize stage using placement
parasitics. Disabled by default; pre-CTS setup/hold repair is skipped
unless this is set to 1.
Comment thread
eder-matheus marked this conversation as resolved.
stages:
- place
default: 0
SKIP_REPAIR_TIE_FANOUT:
description: >
Skip repair_tie_fanout at floorplan step.
Expand Down Expand Up @@ -1189,11 +1197,6 @@ POST_PDN_TCL:
Specifies a Tcl script with commands to run after PDN generation.
stages:
- floorplan
POST_REPAIR_TIMING_POST_PLACE_TCL:
description: |
Specifies a Tcl script with commands to run after post-place timing repair.
stages:
- place
POST_RESIZE_TCL:
description: |
Specifies a Tcl script with commands to run after resize.
Expand Down Expand Up @@ -1269,11 +1272,6 @@ PRE_PDN_TCL:
Specifies a Tcl script with commands to run before PDN generation.
stages:
- floorplan
PRE_REPAIR_TIMING_POST_PLACE_TCL:
description: |
Specifies a Tcl script with commands to run before post-place timing repair.
stages:
- place
PRE_RESIZE_TCL:
description: |
Specifies a Tcl script with commands to run before resize.
Expand Down