Skip to content

updates for EST fixes #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 4 commits into from
Jun 1, 2026
Merged

updates for EST fixes #4271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b68587
use est_check_delay_calc branch
eder-matheus May 29, 2026
ada84b4
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
eder-matheus Jun 1, 2026
0b40182
bump openroad
eder-matheus Jun 1, 2026
54beddf
update asap7/gcd-ccs core util and metrics
eder-matheus Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions flow/designs/asap7/gcd-ccs/config.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
export DESIGN_NICKNAME = gcd-ccs
export LIB_MODEL = CCS
include designs/asap7/gcd/config.mk

# Lower the core utilization from 65 (base asap7/gcd) to 60
# due to a DPL failure at the global route stage due to extra
# buffers inserted by repair_timing
export CORE_UTILIZATION = 60
16 changes: 8 additions & 8 deletions flow/designs/asap7/gcd-ccs/rules-base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"synth__canonical_netlist__hash": {
"value": "9b1daddbf16520e983085be7f06a02bc2fc2e27a",
"value": "7250dc152c2381ac020b86c78a5191b1c336244b",
"compare": "==",
"level": "warning"
},
"synth__netlist__hash": {
"value": "2d3fbf9f1b7357c0cadb1e193d984ae458d68fa8",
"value": "a954b979a1a0eff89ed870fa50d202847b6807bf",
"compare": "==",
"level": "warning"
},
Expand Down Expand Up @@ -38,11 +38,11 @@
"compare": "<="
},
"cts__timing__setup__ws": {
"value": -63.5,
"value": -79.2,
"compare": ">="
},
"cts__timing__setup__tns": {
"value": -773.0,
"value": -1260.0,

@gemini-code-assist gemini-code-assist Bot Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The timing metrics show a significant degradation (e.g., cts__timing__setup__tns degrading from -773.0 to -1260.0 and globalroute__timing__setup__tns from -771.0 to -1530.0). Per the repository guidelines, merging updates to regression baselines with significant degradation is acceptable only if there is an explicit agreement or tracking issue to address the underlying timing issue later. Please document this agreement or reference the tracking issue in the PR description.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

@eder-matheus eder-matheus Jun 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This large degradations are explained by the fixes on the estimate_parasitics command. For this design, which uses set_delay_calculator prima, wire delay was always zero due to a bug. Now we're properly estimating parasitics for it.

"compare": ">="
},
"cts__timing__hold__ws": {
Expand All @@ -58,11 +58,11 @@
"compare": "<="
},
"globalroute__timing__setup__ws": {
"value": -63.5,
"value": -93.7,
"compare": ">="
},
"globalroute__timing__setup__tns": {
"value": -771.0,
"value": -1530.0,
"compare": ">="
},
"globalroute__timing__hold__ws": {
Expand Down Expand Up @@ -90,11 +90,11 @@
"compare": "<="
},
"finish__timing__setup__ws": {
"value": -84.2,
"value": -78.5,
"compare": ">="
},
"finish__timing__setup__tns": {
"value": -1200.0,
"value": -1190.0,
"compare": ">="
},
"finish__timing__hold__ws": {
Expand Down
2 changes: 1 addition & 1 deletion tools/OpenROAD
Open in desktop
Submodule OpenROAD updated 17 files
+9 −1 src/est/include/est/EstimateParasitics.h
+61 −20 src/est/src/EstimateParasitics.cpp
+18 −72 src/est/src/MakeWireParasitics.cpp
+19 −0 src/est/test/BUILD
+27 −0 src/est/test/CMakeLists.txt
+287 −0 src/est/test/cpp/TestEstimateParasitics.cc
+26 −0 src/est/test/cpp/TestEstimateParasitics.v
+100 −0 src/grt/src/fastroute/src/FastRoute.cpp
+2 −2 src/grt/test/est_rc3.ok
+4 −4 src/grt/test/est_rc4.ok
+946 −1,391 src/grt/test/est_rc4_corner0.spefok
+946 −1,391 src/grt/test/est_rc4_corner1.spefok
+4 −2 src/ram/README.md
+12 −9 src/ram/src/ram.tcl
+7 −1 src/rsz/include/rsz/Resizer.hh
+1 −1 src/sta
+1 −0 src/syn/src/elab/BUILD