Skip to content

Fix logic to extract design stage #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 6 commits into from
Jun 11, 2026
Merged

Fix logic to extract design stage #4286

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9378d6
test secure ci with dbsta lev drv cleanup
dsengupta0628 May 29, 2026
4c88e06
update OR
dsengupta0628 Jun 1, 2026
645a369
fix the util regexp
dsengupta0628 Jun 10, 2026
bfc0161
Merge branch 'master' into secure-fix_extract_design
dsengupta0628 Jun 10, 2026
0b46c28
address gemini review
dsengupta0628 Jun 10, 2026
f853b11
cleanup
dsengupta0628 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flow/scripts/util.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ proc recover_power_helper { } {
}

proc extract_stage { input_file } {
if { ![regexp {/([0-9])_(([0-9])_)?} $input_file match num1 _ num2] } {
# Match the stage prefix on the basename, not the full path: an ancestor
# dir like ".../4_slices/3_place.odb" would otherwise match "4_" -> stage 4.
set stage_file [file tail $input_file]
if { ![regexp {^([0-9])_(([0-9])_)?} $stage_file match num1 _ num2] } {

@gemini-code-assist gemini-code-assist Bot Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a non-capturing group (?:...) for the optional second stage number allows you to avoid capturing the intermediate _ group (e.g., 2_), which eliminates the need for the dummy variable _ in the regexp variable list. This makes the regular expression and the variable bindings cleaner and more maintainable.

  if { ![regexp {^([0-9])_(?:([0-9])_)?} $stage_file match num1 num2] } {

puts "Error: Could not determine design stage from $input_file"
exit 1
}
Expand Down