Skip to content

docs: add Docker quickstart for gcd on nangate45#4303

Open
fusang991 wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
fusang991:docs/quickstart-gcd-nangate45
Open

docs: add Docker quickstart for gcd on nangate45#4303
fusang991 wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
fusang991:docs/quickstart-gcd-nangate45

Conversation

@fusang991

Copy link
Copy Markdown

Add a short verified walkthrough for the default ORFS smoke test and fix the GDS output path in index.md to include the base flow variant.

Add a short verified walkthrough for the default ORFS smoke test and fix
the GDS output path in index.md to include the base flow variant.

Signed-off-by: fusang <fusang991@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Docker-based quickstart guide for running the gcd design on the nangate45 platform, updating the documentation index, table of contents, and tutorial homepage to link to it. The review feedback focuses on correcting corrupted em-dash characters in the text and ensuring that the documented file paths are consistent with the instructed working directory by removing redundant directory prefixes.

Comment on lines +3 to +4
This guide runs the smallest ORFS smoke test �� the `gcd` design on the
`nangate45` platform �� from RTL to GDS using the pre-built Docker image.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The text contains garbled characters (`` or ¡ª) which appear to be a corrupted em-dash. Replacing them with a standard UTF-8 em-dash (`—`) ensures proper rendering across all platforms and browsers.

Suggested change
This guide runs the smallest ORFS smoke test �� the `gcd` design on the
`nangate45` platform �� from RTL to GDS using the pre-built Docker image.
This guide runs the smallest ORFS smoke test the `gcd` design on the
`nangate45` platform from RTL to GDS using the pre-built Docker image.

Comment on lines +51 to +55
| Artifact | Path |
|----------|------|
| GDSII | `flow/results/nangate45/gcd/base/6_final.gds` |
| DEF | `flow/results/nangate45/gcd/base/6_final.def` |
| Logs | `flow/logs/nangate45/gcd/base/` |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The paths in this table include the flow/ prefix, but the user was instructed to cd flow in the previous section. To avoid confusion and match the ls command on line 60, these paths should be relative to the flow directory.

Suggested change
| Artifact | Path |
|----------|------|
| GDSII | `flow/results/nangate45/gcd/base/6_final.gds` |
| DEF | `flow/results/nangate45/gcd/base/6_final.def` |
| Logs | `flow/logs/nangate45/gcd/base/` |
| Artifact | Path |
|----------|------|
| GDSII | `results/nangate45/gcd/base/6_final.gds` |
| DEF | `results/nangate45/gcd/base/6_final.def` |
| Logs | `logs/nangate45/gcd/base/` |

- Image: `openroad/orfs:latest`
- Command: `util/docker_shell make DESIGN_CONFIG=./designs/nangate45/gcd/config.mk`
- Full clean run (`make clean_all` then `make`): ~61 seconds wall time
- Output: `flow/results/nangate45/gcd/base/6_final.gds` present

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the updated table and the active directory (flow/), the output path here should also omit the flow/ prefix.

Suggested change
- Output: `flow/results/nangate45/gcd/base/6_final.gds` present
- Output: `results/nangate45/gcd/base/6_final.gds` present

Use ASCII dashes and paths relative to the flow directory for consistency.

Signed-off-by: fusang <fusang991@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants