Skip to content

Commit 165dbe2

Browse files
authored
Merge pull request #10841 from oharboe/bump-bazel-orfs
bazel: bump bazel-orfs to 60d62021, upgrade yosys to 0.64
2 parents b678131 + 2216dbd commit 165dbe2

5 files changed

Lines changed: 63 additions & 75 deletions

File tree

MODULE.bazel

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ bazel_dep(name = "rules_nodejs", version = "6.7.3", dev_dependency = True)
192192
bazel_dep(name = "bazel-orfs", dev_dependency = True)
193193
bazel_dep(name = "bazel-orfs-verilog", dev_dependency = True)
194194

195-
BAZEL_ORFS_COMMIT = "78f19f25cec73bdec3517a76465dec7ce17ce227"
195+
BAZEL_ORFS_COMMIT = "60d62021c779e64ef7360a1b08a8faee00183c8d"
196196

197197
BAZEL_ORFS_REMOTE = "https://github.com/The-OpenROAD-Project/bazel-orfs.git"
198198

@@ -210,27 +210,30 @@ git_override(
210210
strip_prefix = "verilog",
211211
)
212212

213-
# bazel-orfs pulls in orfs without a version and patches yosys, relying on
214-
# overrides that only apply when bazel-orfs is the root module. Mirror them
215-
# here so OpenROAD-as-root can resolve the module graph.
213+
# @orfs marks most non-root-only directives (qt-bazel/yosys-slang git_overrides,
214+
# orfs.default(), toolchain registration) as dev_dependency, so they are no-ops
215+
# here. But @orfs//flow loads @bazel-orfs//:openroad.bzl, and @orfs marks its
216+
# bazel-orfs bazel_dep dev_dependency too, which drops @bazel-orfs from @orfs's
217+
# repo mapping when consumed non-root — so loading @orfs//flow fails. The patch
218+
# makes that one bazel_dep non-dev.
216219
#
217220
# Use archive_override (HTTPS tarball) rather than git_override so the
218221
# build resolves on networks that block direct git access to github.com.
219-
ORFS_COMMIT = "10a2baea2171059ec14cda9a5855aa26dd7572c6"
222+
ORFS_COMMIT = "4b3f2663609fd3f6fd8d862729de1ec5967eb4e6"
220223

221224
bazel_dep(name = "orfs", dev_dependency = True)
222225
archive_override(
223226
module_name = "orfs",
224227
patch_strip = 1,
225228
patches = [
226-
"//bazel/bazel-orfs-patches:0035-fix-remove-non-root-overrides-from-MODULE.bazel.patch",
229+
"//bazel/bazel-orfs-patches:0035-orfs-bazel-orfs-visible-non-root.patch",
227230
],
228-
sha256 = "8325c6755215857a87a84db078d47dfbb2dfcbef70eaf0dd376fe5a7a363cd58",
231+
sha256 = "b6e496221b5be5a5ecd54e978a7a8157a212b67374e2ecd6c27f90d35e02b473",
229232
strip_prefix = "OpenROAD-flow-scripts-" + ORFS_COMMIT,
230233
urls = ["https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/archive/" + ORFS_COMMIT + ".tar.gz"],
231234
)
232235

233-
bazel_dep(name = "yosys", version = "0.62.bcr.2", dev_dependency = True)
236+
bazel_dep(name = "yosys", version = "0.64", dev_dependency = True)
234237
bazel_dep(name = "yosys-slang", version = "0.0.0", dev_dependency = True)
235238
archive_override(
236239
module_name = "yosys-slang",

MODULE.bazel.lock

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bazel/bazel-orfs-patches/0035-fix-remove-non-root-overrides-from-MODULE.bazel.patch

Lines changed: 0 additions & 49 deletions
This file was deleted.
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2+
From: Oyvind Harboe <oyvind.harboe@zylin.com>
3+
Date: Wed, 8 Jul 2026 00:00:00 +0000
4+
Subject: [PATCH] orfs: keep bazel-orfs visible when orfs is a non-root dep
5+
6+
@orfs//flow loads @bazel-orfs//:openroad.bzl, so @bazel-orfs must be in
7+
@orfs's repo mapping. Upstream marks the bazel-orfs bazel_dep as
8+
dev_dependency, which drops it from the mapping when @orfs is consumed
9+
as a non-root dependency, so loading @orfs//flow fails with "No
10+
repository visible as '@bazel-orfs' from repository '@@orfs+'". Make the
11+
bazel_dep non-dev; the bazel-orfs version is unified by the root
12+
module's pin either way.
13+
14+
Signed-off-by: Oyvind Harboe <oyvind.harboe@zylin.com>
15+
---
16+
--- a/MODULE.bazel
17+
+++ b/MODULE.bazel
18+
@@ -33,7 +33,7 @@
19+
remote = "https://github.com/The-OpenROAD-Project/qt_bazel_prebuilts",
20+
)
21+
22+
-bazel_dep(name = "bazel-orfs", dev_dependency = True)
23+
+bazel_dep(name = "bazel-orfs")
24+
bazel_dep(name = "bazel-orfs-verilog", dev_dependency = True)
25+
26+
BAZEL_ORFS_COMMIT = "6ebadeb4be5c9ada103081c9a5e668c014126616"

test/orfs/gcd/rules-base.json

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,44 @@
11
{
2-
"synth__design__instance__area__stdcell": {
3-
"value": 44.3,
4-
"compare": "<="
2+
"synth__canonical_netlist__hash": {
3+
"value": "6b5b245a1b16c0ed5e17c85030fd38266f2c0a2c",
4+
"compare": "==",
5+
"level": "warning"
6+
},
7+
"synth__netlist__hash": {
8+
"value": "407871ad5bca7d0c3fcfc33d4017971cd7b67dfa",
9+
"compare": "==",
10+
"level": "warning"
511
},
612
"constraints__clocks__count": {
713
"value": 1,
814
"compare": "=="
915
},
1016
"placeopt__design__instance__area": {
11-
"value": 59,
17+
"value": 63,
1218
"compare": "<="
1319
},
1420
"placeopt__design__instance__count__stdcell": {
15-
"value": 613,
21+
"value": 668,
1622
"compare": "<="
1723
},
1824
"detailedplace__design__violations": {
1925
"value": 0,
2026
"compare": "=="
2127
},
2228
"cts__design__instance__count__setup_buffer": {
23-
"value": 53,
29+
"value": 58,
2430
"compare": "<="
2531
},
2632
"cts__design__instance__count__hold_buffer": {
27-
"value": 53,
33+
"value": 58,
2834
"compare": "<="
2935
},
3036
"cts__timing__setup__ws": {
31-
"value": -79.8,
37+
"value": -81.9,
3238
"compare": ">="
3339
},
3440
"cts__timing__setup__tns": {
35-
"value": -1710.0,
41+
"value": -1320.0,
3642
"compare": ">="
3743
},
3844
"cts__timing__hold__ws": {
@@ -48,11 +54,11 @@
4854
"compare": "<="
4955
},
5056
"globalroute__timing__setup__ws": {
51-
"value": -85.4,
57+
"value": -93.8,
5258
"compare": ">="
5359
},
5460
"globalroute__timing__setup__tns": {
55-
"value": -1910.0,
61+
"value": -1560.0,
5662
"compare": ">="
5763
},
5864
"globalroute__timing__hold__ws": {
@@ -64,7 +70,7 @@
6470
"compare": ">="
6571
},
6672
"detailedroute__route__wirelength": {
67-
"value": 1403,
73+
"value": 1603,
6874
"compare": "<="
6975
},
7076
"detailedroute__route__drc_errors": {
@@ -80,11 +86,11 @@
8086
"compare": "<="
8187
},
8288
"finish__timing__setup__ws": {
83-
"value": -71.0,
89+
"value": -79.7,
8490
"compare": ">="
8591
},
8692
"finish__timing__setup__tns": {
87-
"value": -1290.0,
93+
"value": -1230.0,
8894
"compare": ">="
8995
},
9096
"finish__timing__hold__ws": {
@@ -96,7 +102,7 @@
96102
"compare": ">="
97103
},
98104
"finish__design__instance__area": {
99-
"value": 66,
105+
"value": 69,
100106
"compare": "<="
101107
}
102108
}

0 commit comments

Comments
 (0)