File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -14,19 +14,23 @@ package(
1414 features = ["layering_check" ],
1515)
1616
17- # Headers owned by :gpl but also consumed by :ui. Kept package-private so
18- # nothing outside //src/gpl can depend on them .
17+ # Headers owned by :gpl but also consumed by :ui and GPL tests. Keep them
18+ # visible only to //src/gpl and its tests .
1919cc_library (
2020 name = "gpl_private_hdrs" ,
2121 hdrs = [
22+ "src/fft.h" ,
2223 "src/nesterovBase.h" ,
2324 "src/nesterovPlace.h" ,
2425 "src/placerBase.h" ,
2526 "src/point.h" ,
2627 "src/routeBase.h" ,
2728 ],
2829 includes = ["src" ],
29- visibility = ["//visibility:private" ],
30+ visibility = [
31+ "//src/gpl/test:__pkg__" ,
32+ "//visibility:private" ,
33+ ],
3034 deps = [
3135 "//src/odb/src/db" ,
3236 "//src/utl" ,
@@ -44,7 +48,6 @@ cc_library(
4448 "src/densityGradient.cpp" ,
4549 "src/densityGradientBackend.h" ,
4650 "src/fft.cpp" ,
47- "src/fft.h" ,
4851 "src/fftBackend.h" ,
4952 "src/fftsg.cpp" ,
5053 "src/fftsg2d.cpp" ,
Original file line number Diff line number Diff line change @@ -144,10 +144,10 @@ PY_TESTS = [
144144cc_test (
145145 name = "gpl_fft_unittest" ,
146146 srcs = ["fft_test.cc" ],
147- features = ["-layering_check" ], # TODO: includes private headers
148147 linkstatic = True , # TODO: remove once deps define all symbols
149148 deps = [
150149 "//src/gpl" ,
150+ "//src/gpl:gpl_private_hdrs" ,
151151 "@googletest//:gtest" ,
152152 "@googletest//:gtest_main" ,
153153 "@spdlog" ,
You can’t perform that action at this time.
0 commit comments