bazel: use portable readlink in bzl lint/fmt tests

`readlink -f` is GNU-only; macOS's BSD readlink lacks -f. Bazel
writes runfiles symlinks with absolute targets, so plain `readlink`
suffices and works on both platforms. Also tighten the precondition
to `-L` since the entry must be a symlink, not just any file.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

Author: oharboe

bazel/bzl_fmt_test.sh

@@ -6,10 +6,10 @@
 set -euo pipefail
 TOOL="$(cd "$(dirname "$1")" && pwd)/$(basename "$1")"
 # MODULE.bazel must be in the sh_test `data` deps so it appears as a
-# runfiles symlink; readlink -f then resolves it to the real workspace.
-# Without the data dep, readlink -f silently returns a bogus path.
-[ -e MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
-WORKSPACE="$(cd "$(dirname "$(readlink -f MODULE.bazel)")" && pwd)"
+# runfiles symlink pointing at the real workspace. `readlink` (no -f,
+# for macOS portability) resolves the absolute path Bazel wrote.
+[ -L MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
+WORKSPACE="$(dirname "$(readlink MODULE.bazel)")"
 cd "$WORKSPACE"
 # `git ls-files` skips submodule contents (src/sta, third-party/abc).
 # Explicit -mode=check -lint=off separates format errors from lint warnings,

bazel/bzl_lint_test.sh

@@ -6,10 +6,10 @@
 set -euo pipefail
 TOOL="$(cd "$(dirname "$1")" && pwd)/$(basename "$1")"
 # MODULE.bazel must be in the sh_test `data` deps so it appears as a
-# runfiles symlink; readlink -f then resolves it to the real workspace.
-# Without the data dep, readlink -f silently returns a bogus path.
-[ -e MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
-WORKSPACE="$(cd "$(dirname "$(readlink -f MODULE.bazel)")" && pwd)"
+# runfiles symlink pointing at the real workspace. `readlink` (no -f,
+# for macOS portability) resolves the absolute path Bazel wrote.
+[ -L MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
+WORKSPACE="$(dirname "$(readlink MODULE.bazel)")"
 cd "$WORKSPACE"
 # `git ls-files` skips submodule contents (src/sta, third-party/abc), so
 # we never try to reformat files owned by another repo.