Merge branch 'master' into cts_fix_exiting_tree_identification

Author: arthurjolo

.github/PULL_REQUEST_TEMPLATE.md

@@ -16,6 +16,8 @@
 - [ ] I have verified that the local build succeeds (`./etc/Build.sh`).
 - [ ] I have run the relevant tests and they pass.
 - [ ] My code follows the repository's formatting guidelines.
+<!-- Delete next item if this PR is not a bug fix or new feature -->
+- [ ] I have included tests to prevent regressions.
 - [ ] **I have signed my commits (DCO).**
 
 ## Related Issues

.github/workflows/github-actions-format-on-push.yml

@@ -23,7 +23,10 @@ jobs:
         run: |
           clang-format --version
           for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
-            if [[ "${file##*.}" =~ ^(h|C|cc|cp|cpp|c++|CPP|cxx|hh)$ && "${file}" != "src/sta/"* && "${file}" != "src/odb/src/codeGenerator/"* ]]; then
+            if [[ "${file##*.}" =~ ^(h|C|cc|cp|cpp|c++|CPP|cxx|hh)$ \
+                  && "${file}" != "src/sta/"* \
+                  && "${file}" != "src/odb/src/codeGenerator/"* \
+                  && "${file}" != "third-party/"* ]]; then
               clang-format --dry-run --Werror $file
             fi
           done

.gitignore

@@ -66,3 +66,5 @@ projectview.bazelproject
 .bazelbsp/
 /buildifier
 tmp/
+
+.playwright-mcp

BUILD.bazel

@@ -197,6 +197,7 @@ cc_binary(
         "//src/gui",
         "//src/sta:opensta_lib",
         "//src/utl",
+        "//src/web",
         "@boost.stacktrace",
         "@rules_cc//cc/runfiles",  # sets BAZEL_CURRENT_REPOSITORY
         "@tcl_lang//:tcl",
@@ -512,6 +513,7 @@ sh_test(
     srcs = ["//bazel:bzl_lint_test.sh"],
     args = ["$(rootpath @buildifier_prebuilt//:buildifier)"],
     data = [
+        "MODULE.bazel",
         "@buildifier_prebuilt//:buildifier",
     ],
     tags = ["local"],
@@ -525,6 +527,7 @@ sh_test(
     srcs = ["//bazel:bzl_fmt_test.sh"],
     args = ["$(rootpath @buildifier_prebuilt//:buildifier)"],
     data = [
+        "MODULE.bazel",
         "@buildifier_prebuilt//:buildifier",
     ],
     tags = ["local"],
@@ -571,6 +574,7 @@ sh_binary(
         "$(rootpath @buildifier_prebuilt//:buildifier)",
     ],
     data = [
+        "MODULE.bazel",
         "tclint.toml",
         "//bazel:bzl_lint_test.sh",
         "//bazel:bzl_tidy.sh",

bazel/bison.bzl

@@ -29,11 +29,11 @@ def correct_bison_env_for_action(env, bison):
 
     bison_env["BISON_PKGDATADIR"] = bison_env["BISON_PKGDATADIR"].replace(
         bison_runfiles_dir,
-        "external/{}".format(bison.owner.workspace_name),
+        "external/{}".format(bison.owner.workspace_name),  # buildifier: disable=external-path
     )
     bison_env["M4"] = bison_env["M4"].replace(
         bison_runfiles_dir,
-        "{}/external/{}".format(bison.root.path, bison.owner.workspace_name),
+        "{}/external/{}".format(bison.root.path, bison.owner.workspace_name),  # buildifier: disable=external-path
     )
 
     return bison_env

bazel/bzl_fmt_test.sh

@@ -4,8 +4,12 @@
 #
 # Check that all Bazel files are properly formatted (no lint warnings).
 set -euo pipefail
-TOOL="$(readlink -f "$1")"
-WORKSPACE="$(dirname "$(readlink -f MODULE.bazel)")"
+TOOL="$(cd "$(dirname "$1")" && pwd)/$(basename "$1")"
+# MODULE.bazel must be in the sh_test `data` deps so it appears as a
+# runfiles symlink pointing at the real workspace. `readlink` (no -f,
+# for macOS portability) resolves the absolute path Bazel wrote.
+[ -L MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
+WORKSPACE="$(dirname "$(readlink MODULE.bazel)")"
 cd "$WORKSPACE"
 # `git ls-files` skips submodule contents (src/sta, third-party/abc).
 # Explicit -mode=check -lint=off separates format errors from lint warnings,

bazel/bzl_lint_test.sh

@@ -4,8 +4,12 @@
 #
 # Lint all Bazel files using buildifier (check-only, with lint warnings).
 set -euo pipefail
-TOOL="$(readlink -f "$1")"
-WORKSPACE="$(dirname "$(readlink -f MODULE.bazel)")"
+TOOL="$(cd "$(dirname "$1")" && pwd)/$(basename "$1")"
+# MODULE.bazel must be in the sh_test `data` deps so it appears as a
+# runfiles symlink pointing at the real workspace. `readlink` (no -f,
+# for macOS portability) resolves the absolute path Bazel wrote.
+[ -L MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
+WORKSPACE="$(dirname "$(readlink MODULE.bazel)")"
 cd "$WORKSPACE"
 # `git ls-files` skips submodule contents (src/sta, third-party/abc), so
 # we never try to reformat files owned by another repo.

bazel/flex.bzl

@@ -26,7 +26,7 @@ def _correct_flex_env_for_action(env, flex):
         flex.owner.workspace_name,
     )
 
-    actual = "{}/external/{}".format(flex.root.path, flex.owner.workspace_name)
+    actual = "{}/external/{}".format(flex.root.path, flex.owner.workspace_name)  # buildifier: disable=external-path
 
     for key, value in flex_env.items():
         flex_env[key] = value.replace(flex_runfiles_dir, actual)

docs/agents/testing.md

@@ -6,10 +6,10 @@ OpenROAD has two types of tests: **integration tests** (Tcl) and **unit tests**
 
 **Every new test MUST be registered in BOTH build systems. Missing either one is a build break.**
 
-| Build System | Registration File | Block/Macro |
-|-------------|-------------------|-------------|
-| **CMake** | `src/<module>/test/CMakeLists.txt` | `or_integration_tests(...)` |
-| **Bazel** | `src/<module>/test/BUILD` | `regression_test(...)` |
+| Build System | Registration File                  | Block/Macro                 |
+| ------------ | ---------------------------------- | --------------------------- |
+| **CMake**    | `src/<module>/test/CMakeLists.txt` | `or_integration_tests(...)` |
+| **Bazel**    | `src/<module>/test/BUILD`          | `regression_test(...)`      |
 
 Forgetting the Bazel `BUILD` file is the most common mistake -- CMake-only registration
 silently passes local `make test` but the **test will be missing from Bazel CI**.
@@ -37,6 +37,12 @@ ctest -R "rsz\.buffer_ports1\.tcl"
 
 Best practice reference: `src/rsz/test/repair_tie12_hier.tcl`
 
+#### Issue Reproduction Tests
+
+For issue reproductions, keep the test case minimal and focused on the failing tool behavior. When floorplanning or placement is not part of the bug, encode the small problem design directly in DEF and use `read_def` after loading the necessary LEF and Liberty files instead of running floorplanning or global placement. This keeps the test simpler and more stable across unrelated OpenROAD behavior changes. Use floorplanning or placement steps when those stages are part of the behavior under test.
+
+#### Checklist
+
 1. **Header comment**: First line must explain the test purpose
    ```tcl
    # [Brief description of the test]

docs/src/test/bazel_developer_activities_check.ok

@@ -0,0 +1 @@
+PASS: Bazel developer activities documentation coverage is adequate.