Skip to content

Commit 4448cce

Browse files
committed
Merge remote-tracking branch 'private/master' into rsz-fix-tie-placement
2 parents 0f375d1 + 559a320 commit 4448cce

546 files changed

Lines changed: 165780 additions & 96611 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.clang-tidy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ Checks: >
4848
-modernize-raw-string-literal,
4949
-modernize-return-braced-init-list,
5050
-modernize-use-auto,
51+
-modernize-use-constraints,
5152
-modernize-use-nodiscard,
5253
-modernize-use-trailing-return-type,
5354
-modernize-use-transparent-functors,

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
- [ ] I have verified that the local build succeeds (`./etc/Build.sh`).
1717
- [ ] I have run the relevant tests and they pass.
1818
- [ ] My code follows the repository's formatting guidelines.
19+
<!-- Delete next item if this PR is not a bug fix or new feature -->
20+
- [ ] I have included tests to prevent regressions.
1921
- [ ] **I have signed my commits (DCO).**
2022

2123
## Related Issues

.github/workflows/github-actions-format-on-push.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ jobs:
2323
run: |
2424
clang-format --version
2525
for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
26-
if [[ "${file##*.}" =~ ^(h|C|cc|cp|cpp|c++|CPP|cxx|hh)$ && "${file}" != "src/sta/"* && "${file}" != "src/odb/src/codeGenerator/"* ]]; then
26+
if [[ "${file##*.}" =~ ^(h|C|cc|cp|cpp|c++|CPP|cxx|hh)$ \
27+
&& "${file}" != "src/sta/"* \
28+
&& "${file}" != "src/odb/src/codeGenerator/"* \
29+
&& "${file}" != "third-party/"* ]]; then
2730
clang-format --dry-run --Werror $file
2831
fi
2932
done

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,3 +66,5 @@ projectview.bazelproject
6666
.bazelbsp/
6767
/buildifier
6868
tmp/
69+
70+
.playwright-mcp

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Detailed guides are in `docs/agents/` subdirectory:
1313

1414
## Critical Rules
1515

16-
1. **Never modify `src/sta/` files** -- OpenSTA is managed upstream (`Sdc.cc`, `Power.cc`, `Sdc.tcl`, etc.). **Only test files may be modified.** All fixes must be in OpenROAD code (e.g., `src/dbSta/`, `src/rsz/`). If OpenSTA code change is inevitable, notify user. Exception: you *may* modify `src/sta/` files temporarily for **debugging purposes** only.
16+
1. **Ask before modifying `src/sta/` files** -- OpenSTA is managed upstream (`Sdc.cc`, `Power.cc`, `Sdc.tcl`, etc.). Prefer fixes in OpenROAD code (e.g., src/dbSta/, src/rsz/) when possible.
1717
2. Run `clang-format -i <files>` for C++ files before commit. **NEVER** for `src/sta/*` and `*.i` files.
1818
3. **Always use `git commit -s`** for DCO compliance.
1919
4. When amending submodule commits, parent repo submodule reference must also be updated via `git submodule update --init --recursive`. It is needed after any merge/pull.

BUILD.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ cc_library(
163163
name = "tcl_readline_setup",
164164
srcs = ["src/tcl_readline_setup.cc"],
165165
hdrs = ["src/tcl_readline_setup.h"],
166+
includes = ["src"],
166167
visibility = ["//src/sta:__pkg__"],
167168
deps = [
168169
"@tcl_lang//:tcl",
@@ -197,6 +198,7 @@ cc_binary(
197198
"//src/gui",
198199
"//src/sta:opensta_lib",
199200
"//src/utl",
201+
"//src/web",
200202
"@boost.stacktrace",
201203
"@rules_cc//cc/runfiles", # sets BAZEL_CURRENT_REPOSITORY
202204
"@tcl_lang//:tcl",
@@ -512,6 +514,7 @@ sh_test(
512514
srcs = ["//bazel:bzl_lint_test.sh"],
513515
args = ["$(rootpath @buildifier_prebuilt//:buildifier)"],
514516
data = [
517+
"MODULE.bazel",
515518
"@buildifier_prebuilt//:buildifier",
516519
],
517520
tags = ["local"],
@@ -525,6 +528,7 @@ sh_test(
525528
srcs = ["//bazel:bzl_fmt_test.sh"],
526529
args = ["$(rootpath @buildifier_prebuilt//:buildifier)"],
527530
data = [
531+
"MODULE.bazel",
528532
"@buildifier_prebuilt//:buildifier",
529533
],
530534
tags = ["local"],
@@ -571,6 +575,7 @@ sh_binary(
571575
"$(rootpath @buildifier_prebuilt//:buildifier)",
572576
],
573577
data = [
578+
"MODULE.bazel",
574579
"tclint.toml",
575580
"//bazel:bzl_lint_test.sh",
576581
"//bazel:bzl_tidy.sh",

MODULE.bazel

Lines changed: 9 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ module(
77

88
# --- Regular dependencies (propagated to downstream consumers via MVS) ---
99

10-
bazel_dep(name = "abc", version = "0.62-yosyshq")
11-
bazel_dep(name = "abseil-cpp", version = "20260107.0")
10+
bazel_dep(name = "abc", version = "0.64-yosyshq.bcr.1")
11+
bazel_dep(name = "abseil-cpp", version = "20260107.1")
1212
bazel_dep(name = "bazel_skylib", version = "1.7.1")
1313
bazel_dep(name = "coin-or-lemon", version = "1.3.1")
14-
bazel_dep(name = "platforms", version = "0.0.11")
14+
bazel_dep(name = "platforms", version = "1.0.0")
1515
bazel_dep(name = "rules_bison", version = "0.3.1")
16-
bazel_dep(name = "rules_cc", version = "0.2.17")
16+
bazel_dep(name = "rules_cc", version = "0.2.18")
1717
bazel_dep(name = "rules_flex", version = "0.3.1")
1818
bazel_dep(name = "rules_pkg", version = "1.2.0")
1919
bazel_dep(name = "rules_python", version = "1.8.5")
@@ -59,17 +59,16 @@ bazel_dep(name = "boost.thread", version = BOOST_VERSION)
5959
bazel_dep(name = "boost.tokenizer", version = BOOST_VERSION)
6060
bazel_dep(name = "boost.unordered", version = BOOST_VERSION)
6161
bazel_dep(name = "boost.utility", version = BOOST_VERSION)
62-
bazel_dep(name = "cudd", version = "3.0.0")
62+
bazel_dep(name = "cudd", version = "3.0.0.bcr.2")
6363
bazel_dep(name = "eigen", version = "3.4.0.bcr.3")
64-
bazel_dep(name = "openmp", version = "21.1.5")
64+
bazel_dep(name = "openmp", version = "21.1.5.bcr.1")
6565
bazel_dep(name = "or-tools", version = "9.15")
66-
bazel_dep(name = "readline", version = "8.2.bcr.3")
6766
bazel_dep(name = "spdlog", version = "1.15.1")
68-
bazel_dep(name = "tcl_lang", version = "8.6.16.bcr.1")
67+
bazel_dep(name = "tcl_lang", version = "9.0.2.bcr.1")
6968
bazel_dep(name = "tclreadline", version = "2.4.1")
7069
bazel_dep(name = "tcmalloc", version = "0.0.0-20250927-12f2552")
7170
bazel_dep(name = "yaml-cpp", version = "0.9.0")
72-
bazel_dep(name = "zlib", version = "1.3.1.bcr.5")
71+
bazel_dep(name = "zlib", version = "1.3.1.bcr.8")
7372

7473
# JavaScript / web UI — only used for JS unit tests in src/web/test
7574
bazel_dep(name = "aspect_rules_js", version = "3.0.2", dev_dependency = True)
@@ -83,7 +82,7 @@ bazel_dep(name = "rules_nodejs", version = "6.7.3", dev_dependency = True)
8382
bazel_dep(name = "qt-bazel")
8483
git_override(
8584
module_name = "qt-bazel",
86-
commit = "df022f4ebaa4130713692fffd2f519d49e9d0b97",
85+
commit = "886104974c2fd72439f2c33b5deebf0fe4649df7",
8786
remote = "https://github.com/The-OpenROAD-Project/qt_bazel_prebuilts",
8887
)
8988

@@ -98,17 +97,6 @@ bazel_dep(name = "buildifier_prebuilt", version = "8.5.1.2", dev_dependency = Tr
9897
bazel_dep(name = "googletest", version = "1.17.0.bcr.2", dev_dependency = True)
9998
bazel_dep(name = "rules_verilator", version = "0.1.0", dev_dependency = True)
10099
bazel_dep(name = "verilator", version = "5.036.bcr.3", dev_dependency = True)
101-
102-
# Used by chisel_binary from @bazel-orfs in test/orfs/mock-array
103-
bazel_dep(name = "rules_jvm_external", version = "6.4", dev_dependency = True)
104-
bazel_dep(name = "rules_chisel", version = "0.2.0", dev_dependency = True)
105-
single_version_override(
106-
module_name = "rules_chisel",
107-
patch_strip = 1,
108-
patches = ["//:rules-chisel-dev-dep.patch"],
109-
)
110-
111-
bazel_dep(name = "rules_scala", version = "7.1.5", dev_dependency = True)
112100
bazel_dep(name = "bazel-orfs", dev_dependency = True)
113101
bazel_dep(name = "bazel-orfs-verilog", dev_dependency = True)
114102

@@ -195,69 +183,6 @@ orfs.default(
195183
)
196184
use_repo(orfs, "docker_orfs")
197185

198-
SCALA_VERSION = "2.13.17"
199-
200-
CHISEL_VERSION = "7.2.0"
201-
202-
FIRTOOL_RESOLVER_VERSION = "2.0.1"
203-
204-
scala_config = use_extension(
205-
"@rules_scala//scala/extensions:config.bzl",
206-
"scala_config",
207-
dev_dependency = True,
208-
)
209-
scala_config.settings(
210-
scala_version = SCALA_VERSION,
211-
)
212-
use_repo(scala_config, "rules_scala_config")
213-
214-
scala_deps = use_extension(
215-
"@rules_scala//scala/extensions:deps.bzl",
216-
"scala_deps",
217-
dev_dependency = True,
218-
)
219-
scala_deps.settings(
220-
fetch_sources = True,
221-
)
222-
scala_deps.scala()
223-
224-
chisel = use_extension("@rules_chisel//chisel:extensions.bzl", "chisel", dev_dependency = True)
225-
chisel.toolchain(
226-
chisel_version = CHISEL_VERSION,
227-
firtool_resolver_version = FIRTOOL_RESOLVER_VERSION,
228-
scala_version = SCALA_VERSION,
229-
)
230-
use_repo(chisel, "chisel_maven")
231-
232-
maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven", dev_dependency = True)
233-
maven.install(
234-
name = "maven",
235-
artifacts = [
236-
],
237-
# Update by running: bazelisk run @maven//:pin
238-
lock_file = "//bazel:maven_install.json",
239-
repositories = [
240-
"https://repo1.maven.org/maven2",
241-
"https://s01.oss.sonatype.org/content/repositories/releases",
242-
"https://s01.oss.sonatype.org/content/repositories/snapshots",
243-
],
244-
)
245-
use_repo(maven, "maven")
246-
247-
# --- External archives ---
248-
249-
http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
250-
251-
http_archive(
252-
name = "circt",
253-
build_file_content = """
254-
exports_files(glob(["bin/*"]), visibility = ["//visibility:public"])
255-
""",
256-
sha256 = "b1b57d1b76ceba2bb37229dab53839d5db6d61394149708c71f6265565991ce6",
257-
strip_prefix = "firtool-1.108.0",
258-
url = "https://github.com/llvm/circt/releases/download/firtool-1.108.0/firrtl-bin-linux-x64.tar.gz",
259-
)
260-
261186
# --- Overrides ---
262187

263188
single_version_override(

0 commit comments

Comments
 (0)