Skip to content

Commit 5afdec3

Browse files
committed
bazel: make toolchains_llvm a dev_dependency
The bazel_dep was non-dev, forcing downstream Bazel consumers to inherit OpenROAD's pinned LLVM toolchain. This conflicts when consumers configure their own C++ toolchain. The extension and toolchain registration were already dev_dependency. Making the bazel_dep dev_dependency too keeps it consistent and invisible to downstream modules. The llvm_prebuilt build_file reference works because dev deps are still resolved for the declaring module's own build. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
1 parent ea66948 commit 5afdec3

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

MODULE.bazel

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,8 @@ git_override(
8888
)
8989

9090
## Lock the compiler version and avoid any local compiler.
91-
## The bazel_dep stays non-dev because llvm_prebuilt's build_file
92-
## references @toolchains_llvm//toolchain:BUILD.llvm_repo.
93-
## The extension and toolchain registration are dev_dependency because
94-
## toolchains_llvm enforces root-module-only extension usage.
9591
## Downstream consumers must configure their own C++ toolchain.
96-
bazel_dep(name = "toolchains_llvm", version = "1.5.0")
92+
bazel_dep(name = "toolchains_llvm", version = "1.5.0", dev_dependency = True)
9793

9894
# --- Dev dependencies (not propagated to downstream consumers) ---
9995

0 commit comments

Comments
 (0)