Commit 5f9a5d5
bazel: bison patch resolves repo name with repo_name(), not hardcoded
Gemini flagged the hardcoded `external/bison+/lib` canonical repo name as
non-portable (Bazel 7 uses `~`, Bazel 8 `+`). Correct in principle — this
repo pins Bazel 8.6.0 so `+` is right for what ships, but the patch is
headed upstream (bison@3.8.2.bcr.8) where it must survive both.
Gemini's suggested `native.repo_name()` does NOT work here: `native` is
undefined at BUILD-file top level (verified: "name 'native' is not
defined"), and BISON_COPTS is a top-level assignment. The bare builtin
`repo_name()` is the one callable there — verified in a scratch Bazel
8.6.0 module that it returns the canonical name with the separator
(`depb+`), so bison resolves to `bison+`, byte-identical to the previous
hardcoding on Bazel 8 and correct on Bazel 7.1+.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>1 parent 3d795c8 commit 5f9a5d5
1 file changed
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
0 commit comments