odb: Avoid unnecessary copy in makeUniqueHierName

Build the unique hierarchy name directly from the sanitized base name.

Coverity reports COPY_INSTEAD_OF_MOVE because the no-suffix path copies a local string through the ternary expression. Start with the sanitized name and append the suffix only when present so neither path needs an extra copy/move temporary.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>

Author: jhkim-pii

src/odb/src/db/dbInsertBuffer.cpp

@@ -539,9 +539,10 @@ std::string dbInsertBuffer::makeUniqueHierName(const dbModule* module,
                                                const char* suffix) const
 {
   // insertBuffer only punches scalar hierarchy ports, never bus ports.
-  std::string scalar_base_name = replaceBracketsWithUnderscores(base_name);
-  std::string name
-      = (suffix == nullptr) ? scalar_base_name : scalar_base_name + suffix;
+  std::string name = replaceBracketsWithUnderscores(base_name);
+  if (suffix != nullptr) {
+    name += suffix;
+  }
   std::string full = block_->makeNewNetName(
       module, name.c_str(), dbNameUniquifyType::IF_NEEDED_WITH_UNDERSCORE);
   return std::string(block_->getBaseName(full.c_str()));