Merge branch 'master' into rename_size_down

Author: erendn

.bazelignore

@@ -7,3 +7,7 @@ third-party/abc/
 tmp
 # standalone workspace for downstream consumer tests
 test/downstream/
+# fmt ships its own BUILD.bazel assuming it is the workspace root; we overlay
+# fmt via new_local_repository(name="fmt"), so hide this nested package from
+# //... discovery (its glob(["include/fmt/*.h"]) matches nothing here).
+third-party/slang-elab/third_party/fmt/support/bazel/

.gitmodules

@@ -4,3 +4,6 @@
 [submodule "src/abc"]
 	path = third-party/abc
 	url = ../../The-OpenROAD-Project/abc.git
+[submodule "third-party/slang-elab"]
+	path = third-party/slang-elab
+	url = https://github.com/povik/yosys-slang

BUILD.bazel

@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright (c) 2025-2025, The OpenROAD Authors
 
+load("@bazel_skylib//rules:build_test.bzl", "build_test")
 load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
 load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
 load("@rules_cc//cc:cc_library.bzl", "cc_library")
@@ -98,6 +99,7 @@ OPENROAD_LIBRARY_DEPS = [
     "//src/exa:ui",
     "//src/fin",
     "//src/gpl",
+    "//src/gpl:ui",
     "//src/grt",
     "//src/grt:ui",
     "//src/ifp",
@@ -128,6 +130,8 @@ OPENROAD_LIBRARY_DEPS = [
     "//src/rsz:ui",
     "//src/stt",
     "//src/stt:ui",
+    "//src/syn",
+    "//src/syn:ui",
     "//src/tap",
     "//src/tap:ui",
     "//src/upf",
@@ -138,12 +142,7 @@ OPENROAD_LIBRARY_DEPS = [
     "//src/web:ui",
     "@abc",
     ":ord",
-] + select(
-    {
-        ":platform_cli": ["//src/gui"],
-        ":platform_gui": ["//src/gui:gui_qt"],
-    },
-)
+]
 
 # Flags applied to top-level OpenROAD targets only. Flags that apply
 # globally to every cc_* target (-Wall, -Wextra, -Wno-sign-compare,
@@ -190,46 +189,113 @@ cc_library(
     ],
 )
 
+# Deps shared by :openroad and :openroad-qt. Kept as a Starlark list
+# rather than a cc_library wrapper because layering_check is enabled
+# package-wide: a deps-only cc_library does not re-export its deps'
+# headers to consumers, so direct binary deps are what each Main.cc
+# include needs to see.
+OPENROAD_MAIN_DEPS = [
+    ":openroad_version",
+    ":opt_notification",
+    ":ord",
+    ":tcl_readline_setup",
+    "//bazel:tcl_library_init",
+    "//src/cut",
+    "//src/sta:opensta_lib",
+    "//src/utl",
+    "//src/web",
+    "@abseil-cpp//absl/base:no_destructor",
+    "@boost.stacktrace",
+    "@rules_cc//cc/runfiles",  # sets BAZEL_CURRENT_REPOSITORY
+    "@tcl_lang//:tcl",
+]
+
 cc_binary(
     name = "openroad",
     srcs = [
         "src/Main.cc",
     ],
     copts = OPENROAD_COPTS,
+    defines = OPENROAD_DEFINES,
     features = ["-use_header_modules"],
     malloc = select({
         "@platforms//os:linux": "@tcmalloc//tcmalloc",
         "@platforms//os:macos": "@bazel_tools//tools/cpp:malloc",
     }),
     visibility = ["//visibility:public"],
+    deps = OPENROAD_MAIN_DEPS + select(
+        {
+            ":platform_cli": [
+                ":openroad_lib",
+                "//src/gui",
+                "//src/gui:gui_stub",
+            ],
+            ":platform_gui": [
+                ":openroad_lib_qt",
+                "//src/gui:gui_qt",
+            ],
+        },
+    ),
+)
+
+# Qt GUI variant. Build explicitly when the interactive GUI is wanted:
+#   bazelisk build //:openroad-qt
+# Additive to the existing `--//:platform=gui //:openroad` flag path —
+# this target is preferable for ad-hoc GUI builds because it does not
+# invalidate `:openroad`'s cache the way flipping the flag does.
+cc_binary(
+    name = "openroad-qt",
+    srcs = [
+        "src/Main.cc",
+    ],
+    copts = OPENROAD_COPTS,
+    defines = OPENROAD_DEFINES,
+    features = ["-use_header_modules"],
+    malloc = select({
+        "@platforms//os:linux": "@tcmalloc//tcmalloc",
+        "@platforms//os:macos": "@bazel_tools//tools/cpp:malloc",
+    }),
+    visibility = ["//visibility:public"],
+    deps = OPENROAD_MAIN_DEPS + [
+        ":openroad_lib_qt",
+        "//src/gui:gui_qt",
+    ],
+)
+
+# CLI variant: the default. What downstream rule libraries pull as a
+# build-time tool, and what `bazelisk build //:openroad` produces.
+cc_library(
+    name = "openroad_lib",
+    srcs = [
+        "src/Design.cc",
+        "src/OpenRoad.cc",
+        "src/Tech.cc",
+        "src/Timing.cc",
+        ":openroad_swig",
+        ":openroad_tcl",
+    ],
+    copts = OPENROAD_COPTS,
+    defines = OPENROAD_DEFINES + ["BUILD_GUI=false"],
+    features = ["-use_header_modules"],
+    includes = [
+        "include",
+    ],
+    visibility = ["//:__subpackages__"],
     deps = [
-        ":openroad_lib",
-        ":openroad_version",
-        ":opt_notification",
-        ":ord",
-        ":tcl_readline_setup",
-        "//bazel:tcl_library_init",
-        "//src/cut",
         "//src/gui",
         "//src/sta:opensta_lib",
-        "//src/utl",
-        "//src/web",
-        "@abseil-cpp//absl/base:no_destructor",
+        "@abseil-cpp//absl/base:core_headers",
+        "@abseil-cpp//absl/synchronization",
         "@boost.stacktrace",
-        "@rules_cc//cc/runfiles",  # sets BAZEL_CURRENT_REPOSITORY
         "@tcl_lang//:tcl",
-    ],
-)
-
-GUI_BUILD_FLAGS = select(
-    {
-        ":platform_cli": ["BUILD_GUI=false"],
-        ":platform_gui": ["BUILD_GUI=true"],
-    },
+    ] + OPENROAD_LIBRARY_DEPS,
 )
 
+# Qt variant: same sources, linked against the Qt GUI implementation.
+# Used by :openroad-qt, and by :openroad when --//:platform=gui is set.
+# Compiled separately (different `BUILD_GUI` define + different gui dep).
 cc_library(
-    name = "openroad_lib",
+    name = "openroad_lib_qt",
     srcs = [
         "src/Design.cc",
         "src/OpenRoad.cc",
@@ -239,13 +305,14 @@ cc_library(
         ":openroad_tcl",
     ],
     copts = OPENROAD_COPTS,
-    defines = OPENROAD_DEFINES + GUI_BUILD_FLAGS,
+    defines = OPENROAD_DEFINES + ["BUILD_GUI=true"],
     features = ["-use_header_modules"],
     includes = [
         "include",
     ],
     visibility = ["//:__subpackages__"],
     deps = [
+        "//src/gui:gui_qt",
         "//src/sta:opensta_lib",
         "@abseil-cpp//absl/base:core_headers",
         "@abseil-cpp//absl/synchronization",
@@ -347,6 +414,7 @@ cc_binary(
         "//src/gpl",
         "//src/grt",
         "//src/gui",
+        "//src/gui:gui_stub",
         "//src/ifp",
         "//src/odb/src/db",
         "//src/par",
@@ -478,6 +546,14 @@ sh_test(
     tags = ["local"],
 )
 
+# Make sure the Qt GUI variant keeps building. :openroad is exercised by
+# downstream rule libraries that pull it as a tool; :openroad-qt has no
+# such consumer in CI, so a build_test pins its compilability.
+build_test(
+    name = "openroad_qt_build_test",
+    targets = [":openroad-qt"],
+)
+
 # ---------------------------------------------------------------------------
 # Lint & tidy targets
 #

MODULE.bazel

@@ -215,6 +215,22 @@ orfs.default(
     yosys_plugins = ["@yosys-slang//src/yosys_plugin:slang.so"],
 )
 
+# --- External archives ---
+
+new_local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "new_local_repository")
+
+new_local_repository(
+    name = "fmt",
+    build_file = "//third-party/slang-elab/third_party:fmt.BUILD",
+    path = "third-party/slang-elab/third_party/fmt",
+)
+
+new_local_repository(
+    name = "slang",
+    build_file = "//third-party/slang-elab/third_party:slang.BUILD",
+    path = "third-party/slang-elab/third_party/slang",
+)
+
 # --- Overrides ---
 
 single_version_override(

bazel/bzl_fmt_test.sh

@@ -11,8 +11,13 @@ TOOL="$(cd "$(dirname "$1")" && pwd)/$(basename "$1")"
 [ -L MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
 WORKSPACE="$(dirname "$(readlink MODULE.bazel)")"
 cd "$WORKSPACE"
-# `git ls-files` skips submodule contents (src/sta, third-party/abc).
+# `-c submodule.recurse=false` keeps git ls-files from descending into
+# submodules (src/sta, third-party/abc, third-party/slang-elab and the
+# fmt sub-submodule nested in it) — we never want to reformat files
+# owned by another repo. The override is needed because CI sets
+# submodule.recurse=true globally.
 # Explicit -mode=check -lint=off separates format errors from lint warnings,
 # and overrides the repo-root .buildifier.json default (mode: fix).
-git ls-files '*.bazel' '*.bzl' '**/BUILD' 'BUILD' '**/WORKSPACE' 'WORKSPACE' -z \
+git -c submodule.recurse=false ls-files \
+        '*.bazel' '*.bzl' '**/BUILD' 'BUILD' '**/WORKSPACE' 'WORKSPACE' -z \
     | xargs -0 "$TOOL" -mode=check -lint=off

bazel/bzl_lint_test.sh

@@ -11,8 +11,12 @@ TOOL="$(cd "$(dirname "$1")" && pwd)/$(basename "$1")"
 [ -L MODULE.bazel ] || { echo "MODULE.bazel missing from runfiles" >&2; exit 1; }
 WORKSPACE="$(dirname "$(readlink MODULE.bazel)")"
 cd "$WORKSPACE"
-# `git ls-files` skips submodule contents (src/sta, third-party/abc), so
-# we never try to reformat files owned by another repo.
+# `-c submodule.recurse=false` keeps git ls-files from descending into
+# submodules (src/sta, third-party/abc, third-party/slang-elab and the
+# fmt sub-submodule nested in it) — we never want to reformat files
+# owned by another repo. The override is needed because CI sets
+# submodule.recurse=true globally.
 # Explicit -mode=check overrides the repo-root .buildifier.json default.
-git ls-files '*.bazel' '*.bzl' '**/BUILD' 'BUILD' '**/WORKSPACE' 'WORKSPACE' -z \
+git -c submodule.recurse=false ls-files \
+        '*.bazel' '*.bzl' '**/BUILD' 'BUILD' '**/WORKSPACE' 'WORKSPACE' -z \
     | xargs -0 "$TOOL" -mode=check -lint=warn

bazel/bzl_tidy.sh

@@ -6,7 +6,11 @@
 set -euo pipefail
 TOOL="$(cd "$(dirname "$1")" && pwd)/$(basename "$1")"
 cd "${BUILD_WORKSPACE_DIRECTORY:-$PWD}"
-# `git ls-files` skips submodule contents (src/sta, third-party/abc),
-# so we never rewrite files owned by another repo.
-git ls-files '*.bazel' '*.bzl' '**/BUILD' 'BUILD' '**/WORKSPACE' 'WORKSPACE' -z \
+# `-c submodule.recurse=false` keeps git ls-files from descending into
+# submodules (src/sta, third-party/abc, third-party/slang-elab and the
+# fmt sub-submodule nested in it) — we never want to rewrite files
+# owned by another repo. The override is needed because CI sets
+# submodule.recurse=true globally.
+git -c submodule.recurse=false ls-files \
+        '*.bazel' '*.bzl' '**/BUILD' 'BUILD' '**/WORKSPACE' 'WORKSPACE' -z \
     | xargs -0 "$TOOL" -mode=fix -lint=fix

etc/DependencyInstaller.sh

@@ -157,6 +157,28 @@ _verify_checksum() {
     _execute "Verifying ${filename} checksum..." bash -c "echo '${checksum}  ${filename}' | md5sum --quiet -c -"
 }
 
+# ------------------------------------------------------------------------------
+# Yosys build dependencies
+# ------------------------------------------------------------------------------
+# OpenROAD itself uses vendored linenoise, so readline is no longer in the
+# base package lists. Yosys still requires it at compile time, so install it
+# here right before the yosys build.
+_install_yosys_dependencies() {
+    if _command_exists "apt-get"; then
+        export DEBIAN_FRONTEND="noninteractive"
+        _execute "Installing libreadline-dev for yosys..." \
+            apt-get -y install --no-install-recommends libreadline-dev
+    elif _command_exists "yum"; then
+        _execute "Installing readline-devel for yosys..." \
+            yum -y install readline-devel
+    elif _command_exists "zypper"; then
+        _execute "Installing readline-devel for yosys..." \
+            zypper -n install readline-devel
+    elif [[ "$OSTYPE" == "darwin"* ]]; then
+        _execute "Installing readline for yosys..." brew install readline
+    fi
+}
+
 # ------------------------------------------------------------------------------
 # Yosys
 # ------------------------------------------------------------------------------
@@ -173,6 +195,7 @@ _install_yosys() {
     local required_version="${YOSYS_VERSION#v}"
     log "Checking Yosys (System: ${yosys_installed_version}, Required: ${required_version})"
     if [[ "${yosys_installed_version}" != "${required_version}" ]]; then
+        _install_yosys_dependencies
         (
             cd "${BASE_DIR}"
             _execute "Cloning Yosys ${YOSYS_VERSION}..." git clone --depth=1 -b "${YOSYS_VERSION}" --recursive https://github.com/YosysHQ/yosys

include/ord/OpenRoad.hh

@@ -130,6 +130,10 @@ namespace web {
 class WebServer;
 }
 
+namespace syn {
+class Synthesis;
+}
+
 namespace ord {
 
 class dbVerilogNetwork;
@@ -184,6 +188,7 @@ class OpenRoad
     return estimate_parasitics_;
   }
   web::WebServer* getWebServer() { return web_server_; }
+  syn::Synthesis* getSynthesis() { return synthesis_; }
 
   // Return the bounding box of the db rows.
   odb::Rect getCore();
@@ -288,6 +293,7 @@ class OpenRoad
   dft::Dft* dft_ = nullptr;
   est::EstimateParasitics* estimate_parasitics_ = nullptr;
   web::WebServer* web_server_ = nullptr;
+  syn::Synthesis* synthesis_ = nullptr;
   utl::ServiceRegistry* service_registry_ = nullptr;
 
   int threads_ = 1;

pyproject.toml

@@ -0,0 +1,7 @@
+[tool.black]
+extend-exclude = '''
+^/third-party/
+'''
+force-exclude = '''
+^/third-party/
+'''