Skip to content

Commit 71b4015

Browse files
committed
odb: rename cut_class to cut_class_rule for clarity
Gemini Code Assist flagged that the local variable `cut_class` (the pointer returned by findTechLayerCutClassRule) was ambiguous and could be confused with a class name string. Rename it to `cut_class_rule` in all three sites where it appears. Also rename `cutclass` → `cut_class` in addSameMetalSharedEdgeSubRule to follow snake_case consistently. The prior name avoided a collision that is now resolved by the cut_class → cut_class_rule rename. Signed-off-by: anh nguyen <areporeporepo@users.noreply.github.com>
1 parent b72e1d4 commit 71b4015

1 file changed

Lines changed: 14 additions & 12 deletions

File tree

src/odb/src/lefin/lefTechLayerCutSpacingParser.cpp

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,10 @@ void addAdjacentCutsSubRule(
114114
}
115115
if (class_name.is_initialized()) {
116116
const auto& cut_class_name = class_name.value();
117-
auto cut_class = layer->findTechLayerCutClassRule(cut_class_name.c_str());
118-
if (cut_class != nullptr) {
119-
parser->rule->setCutClass(cut_class);
117+
auto cut_class_rule
118+
= layer->findTechLayerCutClassRule(cut_class_name.c_str());
119+
if (cut_class_rule != nullptr) {
120+
parser->rule->setCutClass(cut_class_rule);
120121
}
121122
}
122123
if (side_parallel_no_prl.is_initialized()) {
@@ -176,18 +177,19 @@ void addSameMetalSharedEdgeSubRule(
176177
odb::dbTechLayerCutSpacingRule::CutSpacingType::SAMEMETALSHAREDEDGE);
177178
auto within = at_c<0>(params);
178179
auto above = at_c<1>(params);
179-
auto cutclass = at_c<2>(params);
180+
auto cut_class = at_c<2>(params);
180181
auto except_two_edges = at_c<3>(params);
181182
auto except_same_via = at_c<4>(params);
182183
parser->rule->setWithin(lefinReader->dbdist(within));
183184
if (above.is_initialized()) {
184185
parser->rule->setAbove(true);
185186
}
186-
if (cutclass.is_initialized()) {
187-
const auto& cut_class_name = cutclass.value();
188-
auto cut_class = layer->findTechLayerCutClassRule(cut_class_name.c_str());
189-
if (cut_class != nullptr) {
190-
parser->rule->setCutClass(cut_class);
187+
if (cut_class.is_initialized()) {
188+
const auto& cut_class_name = cut_class.value();
189+
auto cut_class_rule
190+
= layer->findTechLayerCutClassRule(cut_class_name.c_str());
191+
if (cut_class_rule != nullptr) {
192+
parser->rule->setCutClass(cut_class_rule);
191193
}
192194
}
193195
if (except_two_edges.is_initialized()) {
@@ -310,9 +312,9 @@ void setCutClass(const std::string& value,
310312
odb::lefTechLayerCutSpacingParser* parser,
311313
odb::dbTechLayer* layer)
312314
{
313-
auto cut_class = layer->findTechLayerCutClassRule(value.c_str());
314-
if (cut_class != nullptr) {
315-
parser->rule->setCutClass(cut_class);
315+
auto cut_class_rule = layer->findTechLayerCutClassRule(value.c_str());
316+
if (cut_class_rule != nullptr) {
317+
parser->rule->setCutClass(cut_class_rule);
316318
}
317319
}
318320
template <typename Iterator>

0 commit comments

Comments
 (0)