bazel: Fix missing parameter test using standard bash conventions

This addresses oharboe's review comment by replacing non-standard
parameter absence checks with standard `[ -n "$1" ]` bash syntax,
and clearly restoring the ORFS-agnostic standalone target evaluation.

Signed-off-by: alokkumardalei-wq <alokkumardalei2@gmail.com>

Author: alokkumardalei-wq

BUILD.bazel

@@ -7,6 +7,7 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")
 load("@rules_pkg//pkg:tar.bzl", "pkg_tar")
 load("@rules_python//python:defs.bzl", "py_library")
 load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
 load("//bazel:notification.bzl", "notification_rule")
 load("//bazel:python_wrap_cc.bzl", "PYTHON_EXTENSION_LINKOPTS", "PYTHON_STABLE_API_DEFINE", "python_wrap_cc")
 load("//bazel:tcl_encode_or.bzl", "tcl_encode")
@@ -422,6 +423,13 @@ sh_binary(
     data = [":tarfile"],
 )
 
+sh_test(
+    name = "install_test",
+    size = "small",
+    srcs = ["//bazel:install_test.sh"],
+    data = ["//bazel:install.sh"],
+)
+
 pkg_tar(
     name = "tarfile",
     srcs = [

bazel/BUILD

@@ -5,7 +5,10 @@ load("@rules_python//python:pip.bzl", "compile_pip_requirements")
 package(features = ["layering_check"])
 
 exports_files(
-    ["install.sh"],
+    [
+        "install.sh",
+        "install_test.sh",
+    ],
     visibility = ["//visibility:public"],
 )
 

bazel/install.sh

@@ -1,13 +1,42 @@
 #!/bin/bash
 set -e
 
-# Install binary and runfiles from bazel build
-# Usage: bazel run :install -- [DEST_DIR]
-# Default: installs to ./bazel-install in the workspace root
+# Install binary and runfiles from bazel build.
+#
+# ORFS context: When OpenROAD is checked out as a submodule of
+# OpenROAD-flow-scripts at tools/OpenROAD/, the ORFS Make flow expects
+# the binary at tools/install/OpenROAD/bin/openroad. This path
+# originates from build_openroad.sh's CMAKE_INSTALL_PREFIX and is
+# hardcoded in flow/scripts/variables.mk:
+#
+#   export OPENROAD_EXE ?= $(abspath $(FLOW_HOME)/../tools/install/OpenROAD/bin/openroad)
+#
+# The Bazel install target was created as a drop-in replacement for
+# the CMake install step, so the suggested ORFS path below matches
+# that convention.
 
-TARFILE=$(cd $BUILD_WORKSPACE_DIRECTORY; bazelisk info bazel-bin)/openroad.tar
+# Support direct execution outside of bazel run
+BUILD_WORKSPACE_DIRECTORY="${BUILD_WORKSPACE_DIRECTORY:-$PWD}"
 
-DEST_DIR=${1:-${BUILD_WORKSPACE_DIRECTORY}/bazel-install}
+TARFILE="${TARFILE:-$(cd "$BUILD_WORKSPACE_DIRECTORY" && bazelisk info bazel-bin)/openroad.tar}"
+
+if [ "$1" == "-f" ]; then
+    DEST_DIR="${BUILD_WORKSPACE_DIRECTORY}/../install/OpenROAD/bin"
+elif [ "$#" -gt 0 ]; then
+    DEST_DIR="$1"
+else
+    echo "Error: Please specify an installation path."
+    echo ""
+    echo "Examples:"
+    echo "  bazel run :install -- ~/.local/bin    # Add to your PATH"
+    echo "  bazel run :install -- ./build/install  # Project-local install"
+    echo ""
+    echo "If you are using ORFS (OpenROAD-flow-scripts), you can use the -f flag"
+    echo "to install to the path that flow/scripts/variables.mk expects:"
+    echo ""
+    echo "  bazel run :install -- -f"
+    exit 1
+fi
 
 mkdir -p "$DEST_DIR"
 cp -f "$TARFILE" "$DEST_DIR"

bazel/install_test.sh

@@ -0,0 +1,46 @@
+#!/bin/bash
+# Test script for bazel/install.sh
+set -e
+
+echo "Running install.sh argument parser tests..."
+
+# Mock the environment to bypass bazelisk info calls in the test sandbox
+export BUILD_WORKSPACE_DIRECTORY="$(mktemp -d)"
+export TARFILE="${BUILD_WORKSPACE_DIRECTORY}/openroad.tar"
+
+# Create a valid, empty tar archive without triggering GNU tar's "cowardly" abort
+touch "${BUILD_WORKSPACE_DIRECTORY}/dummy.txt"
+tar -cf "$TARFILE" -C "${BUILD_WORKSPACE_DIRECTORY}" dummy.txt
+
+echo "Mock TARFILE created at: $TARFILE"
+
+# Test 1: Passing explicit destination path
+TEST1_DEST="${BUILD_WORKSPACE_DIRECTORY}/dest1"
+echo "--- Test 1: Explicit Destination ---"
+./bazel/install.sh "$TEST1_DEST"
+if [ ! -d "$TEST1_DEST" ]; then
+    echo "FAIL: Test 1 did not create the explicit destination directory."
+    exit 1
+fi
+echo "PASS: Test 1"
+
+# Test 2: Passing the -f flag for ORFS location
+TEST2_DEST="${BUILD_WORKSPACE_DIRECTORY}/../install/OpenROAD/bin"
+echo "--- Test 2: ORFS -f Flag ---"
+./bazel/install.sh -f
+if [ ! -d "$TEST2_DEST" ]; then
+    echo "FAIL: Test 2 did not correctly resolve the -f ORFS destination."
+    exit 1
+fi
+echo "PASS: Test 2"
+
+# Test 3: Passing no arguments (Should fail with error message)
+echo "--- Test 3: No Arguments Expected Failure ---"
+if ./bazel/install.sh; then
+    echo "FAIL: Test 3 succeeded when it should have blocked empty arguments."
+    exit 1
+else
+    echo "PASS: Test 3 correctly aborted."
+fi
+
+echo "All tests passed successfully!"