Merge remote-tracking branch 'origin/master' into lef_parsing_jetski

Author: QuantamHD

.claude/skills/triage-issue/SKILL.md .agents/skills/triage-issue/SKILL.md.claude/skills/triage-issue/SKILL.md renamed to .agents/skills/triage-issue/SKILL.md

@@ -0,0 +1 @@
+../.agents/skills

.claude/skills

@@ -0,0 +1,2 @@
+description = "Triage an OpenROAD GitHub issue by reproducing the bug and minimizing the test case with whittle.py. Use when an issue has an attached tarball artifact (.tar.gz) from `make *_issue`."
+prompt = "Activate the triage-issue skill and triage the following issue: {{args}}"

.gemini/commands/triage-issue.toml

@@ -0,0 +1,5 @@
+{
+  "context": {
+    "fileName": "AGENTS.md"
+  }
+}

.gemini/settings.json

@@ -0,0 +1,20 @@
+# OpenROAD - AI agent context
+
+This file provides project-specific guidance for AI agent sessions working on the OpenROAD codebase.
+
+## Quick Reference
+
+Detailed guides are in `docs/agents/` subdirectory:
+
+- **Build Pitfalls**: See `docs/agents/build.md`
+- **Testing Guide**: See `docs/agents/testing.md`
+- **Git & CI**: See `docs/agents/ci.md`
+- **Coding Patterns**: See `docs/agents/coding.md`
+
+## Critical Rules
+
+1. **Never modify `src/sta/` files** -- OpenSTA is managed upstream (`Sdc.cc`, `Power.cc`, `Sdc.tcl`, etc.). **Only test files may be modified.** All fixes must be in OpenROAD code (e.g., `src/dbSta/`, `src/rsz/`). If OpenSTA code change is inevitable, notify user. Exception: you *may* modify `src/sta/` files temporarily for **debugging purposes** only.
+2. Run `clang-format -i <files>` for C++ files before commit. **NEVER** for `src/sta/*` and `*.i` files.
+3. **Always use `git commit -s`** for DCO compliance.
+4. When amending submodule commits, parent repo submodule reference must also be updated via `git submodule update --init --recursive`. It is needed after any merge/pull.
+5. **Trace bugs upstream** -- when a bug appears in output (e.g., Verilog), find the data creation point (e.g., `buffer_ports`, `remove_buffers`), not the serialization point (e.g., `VerilogWriter`).

AGENTS.md

@@ -166,9 +166,6 @@ cc_binary(
         "src/Main.cc",
     ],
     copts = OPENROAD_COPTS,
-    data = [
-        "@tclreadline//:tclreadline_scripts",
-    ],
     features = ["-use_header_modules"],
     malloc = select({
         "@platforms//os:linux": "@tcmalloc//tcmalloc",
@@ -180,13 +177,13 @@ cc_binary(
         ":openroad_version",
         ":opt_notification",
         ":ord",
-        "//bazel:runfiles",
+        "//bazel:tcl_library_init",
+        "@rules_cc//cc/runfiles",  # sets BAZEL_CURRENT_REPOSITORY
         "//src/cut",
         "//src/gui",
         "//src/sta:opensta_lib",
         "//src/utl",
         "@boost.stacktrace",
-        "@rules_cc//cc/runfiles",
         "@tcl_lang//:tcl",
         # tclreadline: provides ENABLE_READLINE define + links libtclreadline.
         # On systems without tclreadline these are empty stub targets (no-op).

BUILD.bazel

@@ -0,0 +1 @@
+AGENTS.md

CLAUDE.md

@@ -15,6 +15,7 @@ bazel_dep(name = "platforms", version = "0.0.11")
 bazel_dep(name = "rules_bison", version = "0.3.1")
 bazel_dep(name = "rules_cc", version = "0.2.17")
 bazel_dep(name = "rules_flex", version = "0.3.1")
+bazel_dep(name = "rules_pkg", version = "1.2.0")
 bazel_dep(name = "rules_python", version = "1.8.5")
 bazel_dep(name = "rules_shell", version = "0.6.1")
 bazel_dep(name = "swig", version = "4.3.0.bcr.2")
@@ -65,6 +66,7 @@ bazel_dep(name = "or-tools", version = "9.15")
 bazel_dep(name = "readline", version = "8.2.bcr.3")
 bazel_dep(name = "spdlog", version = "1.15.1")
 bazel_dep(name = "tcl_lang", version = "8.6.16.bcr.1")
+bazel_dep(name = "tclreadline", version = "2.4.1")
 bazel_dep(name = "tcmalloc", version = "0.0.0-20250927-12f2552")
 bazel_dep(name = "yaml-cpp", version = "0.9.0")
 bazel_dep(name = "zlib", version = "1.3.1.bcr.5")
@@ -97,7 +99,6 @@ bazel_dep(name = "toolchains_llvm", version = "1.5.0")
 
 bazel_dep(name = "bant", version = "0.2.4", dev_dependency = True)
 bazel_dep(name = "googletest", version = "1.17.0.bcr.2", dev_dependency = True)
-bazel_dep(name = "rules_pkg", version = "1.2.0", dev_dependency = True)
 bazel_dep(name = "rules_verilator", version = "0.1.0", dev_dependency = True)
 bazel_dep(name = "verilator", version = "5.036.bcr.3", dev_dependency = True)
 
@@ -249,16 +250,6 @@ use_repo(maven, "maven")
 
 http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-http_archive(
-    name = "tclreadline",
-    build_file = "//bazel:tclreadline.BUILD",
-    sha256 = "a64e0faed5957b8e1ac16f179948e21cdd6d3b8313590b7ab049a3192ab864fb",
-    strip_prefix = "tclreadline-2.3.8",
-    urls = [
-        "https://github.com/flightaware/tclreadline/archive/refs/tags/v2.3.8.tar.gz",
-    ],
-)
-
 http_archive(
     name = "circt",
     build_file_content = """

MODULE.bazel

@@ -1,7 +1,12 @@
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
+load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
 load("@rules_cc//cc:cc_library.bzl", "cc_library")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "strip_prefix")
+load("@rules_pkg//pkg:zip.bzl", "pkg_zip")
 load("@rules_python//python:pip.bzl", "compile_pip_requirements")
 load("@rules_python//python/entry_points:py_console_script_binary.bzl", "py_console_script_binary")
+load("//bazel:extract_zip.bzl", "extract_zip")
 
 package(features = ["layering_check"])
 
@@ -36,17 +41,99 @@ compile_pip_requirements(
     requirements_txt = "requirements_lock_3_13.txt",
 )
 
-cc_library(
-    name = "runfiles",
+# Various tcl libraries that we want to embed into the binary.
+pkg_files(
+    name = "tcl_core_files",
+    srcs = ["@tcl_lang//:tcl_core"],
+    strip_prefix = strip_prefix.from_root(),
+)
+
+pkg_files(
+    name = "tclreadline_files",
+    srcs = ["@tclreadline//:tclreadline_scripts"],
+    prefix = "tclreadline",
+    strip_prefix = strip_prefix.from_root(),
+)
+
+# Packaging up all tcl resources to one complete zip file. It can be
+# directly embedded in Tcl9 in a //zipfs:/ vfs.
+pkg_zip(
+    name = "tcl_resources_zip",
     srcs = [
-        "InitRunFiles.cpp",
-    ],
-    data = [
-        "@tcl_lang//:tcl_core",
+        ":tcl_core_files",
+        ":tclreadline_files",
     ],
+)
+
+# ... however, Tcl8 still needs access to a directory, so unpack in that case.
+extract_zip(
+    name = "tcl_resources_dir",
+    src = ":tcl_resources_zip",
+)
+
+genrule(
+    name = "tcl_resources_zip_data_h",
+    srcs = [":tcl_resources_zip"],
+    outs = ["tcl_resources_zip_data.h"],
+    cmd = "$(location :embed) kTclResourceZip $< $@",
+    tools = [":embed"],
+)
+
+cc_binary(
+    name = "embed",
+    srcs = ["embed.cc"],
+)
+
+# As long as we support tcl8 (using runfiles) we need this flag.
+bool_flag(
+    name = "use_zipfs",
+    build_setting_default = False,  # False until we can use tcl9
+)
+
+config_setting(
+    name = "zipfs_config",
+    flag_values = {":use_zipfs": "true"},
+)
+
+# Library initialization is a bit different for tcl8 and tcl9.
+# In tcl9, we can use a zipped version of the needed include files, but
+# for tcl8, we have to use the unpacked zip file and point our runfiles
+# to it.
+cc_library(
+    name = "tcl_library_init",
+    srcs = ["tcl_library_init.cc"] +
+           select({
+               ":zipfs_config": ["tcl_resources_zip_data.h"],
+               "//conditions:default": [],
+           }),
+    hdrs = ["tcl_library_init.h"],
+    copts = select({
+        ":zipfs_config": [],
+        "//conditions:default": ["-DUSE_TCL_RUNFILE_INIT"],
+    }),
+    data = select({
+        ":zipfs_config": [],
+        "//conditions:default": [":tcl_resources_dir"],
+    }),
+    visibility = ["//visibility:public"],
+    deps = [
+        "@tcl_lang//:tcl",
+    ] + select({
+        ":zipfs_config": [],
+        "//conditions:default": ["@rules_cc//cc/runfiles"],
+    }),
+)
+
+# shim old library as it is still referenced in src/sta, implementing the
+# old behavior.
+cc_library(
+    name = "runfiles",
+    srcs = ["InitRunFiles.cpp"],
+    data = [":tcl_resources_dir"],
     visibility = ["//visibility:public"],
     deps = [
         "@rules_cc//cc/runfiles",
+        "@tcl_lang//:tcl",
     ],
     alwayslink = True,
 )