Merge remote-tracking branch 'origin/master' into secure-rsz-time-borrow-opt

# Conflicts:
#	src/rsz/test/cpp/CMakeLists.txt

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>

Author: jhkim-pii

.bazelrc

@@ -83,6 +83,20 @@ build --cxxopt "-Wno-deprecated-copy-with-user-provided-copy"  --host_cxxopt "-W
 build --per_file_copt=.*external/.*@-w
 build --host_per_file_copt=.*external/.*@-w
 
+# Treat include paths into external/ (bzlmod/BCR deps) as -isystem so clang
+# suppresses ALL warnings from third-party headers pulled into our TUs (boost,
+# Eigen, googletest, ...), regardless of the specific warning. The
+# per_file_copt -w above only covers compiling external *source* files; this
+# covers external *headers* included by our own sources.
+#
+# The feature is global (target and exec config) and also demotes a from-source
+# dep's own -iquote entries to -isystem. Tools that rely on -iquote precedence
+# to shadow libc headers are patched to restore it -- e.g. git's
+# builtin/get-tar-commit-id.c includes git's own tar.h, which must win over
+# glibc's <tar.h>. See the git single_version_override in MODULE.bazel (same
+# class of fix as the bison/sed/gawk/m4 -I-over-isystem overrides).
+build --features=external_include_paths
+
 # This avoid problems with building -c dbg which enables asserts.
 # Without this libstdc++ vs libc++ differences cause link errors.
 build --per_file_copt=.*external/abc.*@-stdlib=libc++
@@ -111,6 +125,9 @@ build:asan --copt=-DADDRESS_SANITIZER
 build:asan --copt=-O1
 build:asan --copt=-g
 build:asan --copt=-fno-omit-frame-pointer
+# Compress the DWARF debug sections (transparent to gdb/perf/addr2line).
+build:asan --copt=-gz=zlib
+build:asan --linkopt=-gz=zlib
 build:asan --linkopt=-fsanitize=address
 # TCMalloc is incompatible with ASan: __asan_init's interceptor setup calls
 # dlsym -> malloc before TCMalloc is initialized, segfaulting at startup.
@@ -123,6 +140,9 @@ build:profile --strip=never
 build:profile --copt -g --host_copt -g
 build:profile --copt -gmlt --host_copt -gmlt
 build:profile --copt -fno-omit-frame-pointer --host_copt -fno-omit-frame-pointer
+# Compress the DWARF debug sections (transparent to gdb/perf/addr2line).
+build:profile --copt=-gz=zlib --host_copt=-gz=zlib
+build:profile --linkopt=-gz=zlib
 
 # Improve hermeticity by disallowing user envars and network access
 build --incompatible_strict_action_env

.bazelversion

@@ -1 +1 @@
-8.6.0
+9.1.1

.github/workflows/buildifier.yaml

@@ -34,7 +34,7 @@ jobs:
 
       - name: Cache buildifier
         id: cache-buildifier
-        uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae  # v5.0.5
+        uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9  # v6.1.0
         with:
           path: ./buildifier
           key: ${{ runner.os }}-buildifier-${{ env.BUILDIFIER_VERSION }}

.github/workflows/github-actions-on-master-push.yml

@@ -29,7 +29,7 @@ jobs:
 
       - name: Cache buildifier
         id: cache-buildifier
-        uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae  # v5.0.5
+        uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9  # v6.1.0
         with:
           path: ./buildifier
           key: ${{ runner.os }}-buildifier-${{ env.BUILDIFIER_VERSION }}

.github/workflows/github-actions-update-grammar-railroad-diagrams.yml

@@ -20,13 +20,13 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
 
       - name: Set up Java
-        uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9  # v4.8.0
+        uses: actions/setup-java@0f481fcb613427c0f801b606911222b5b6f3083a  # v5.5.0
         with:
           distribution: temurin
           java-version: "21"
 
       - name: Cache railroad diagram tools
-        uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae  # v5.0.5
+        uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9  # v6.1.0
         id: cache-tools
         with:
           path: src/odb/doc/tools
@@ -82,7 +82,7 @@ jobs:
 
       - name: Open PR if diagrams changed
         if: steps.diagram-changes.outputs.changed == 'true'
-        uses: peter-evans/create-pull-request@22a9089034f40e5a961c8808d113e2c98fb63676  # v7.0.11
+        uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1  # v8.1.1
         with:
           commit-message: "odb: regenerate LEF/DEF railroad diagram SVGs"
           branch: auto/grammar-railroad-diagrams

CMakeLists.txt

@@ -75,7 +75,10 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
 
-set_property(DIRECTORY PROPERTY TEST_DISCOVERY_TIMEOUT 60)
+# Defer GoogleTest case discovery from build time (POST_BUILD default, which
+# execs each test binary during the build) to ctest time. On a loaded CI host
+# the build-time discovery run can exceed the timeout and fail the whole build.
+set(CMAKE_GTEST_DISCOVER_TESTS_DISCOVERY_MODE PRE_TEST)
 
 # Get version string in OPENROAD_VERSION
 if(NOT OPENROAD_VERSION)
@@ -180,6 +183,25 @@ if (LINK_TIME_OPTIMIZATION AND NOT LTO_UNSUPPORTED_OS)
 endif()
 message(STATUS "LTO/IPO is ${LTO_STATUS}")
 
+# Compress DWARF debug sections in builds that emit debug info. This is a
+# large on-disk win for template-heavy C++ (debug info dominates these
+# binaries) and is transparent to gdb/readelf/addr2line/lldb. It is a no-op
+# for builds without -g (e.g. Release), so it is safe to apply globally.
+# Excluded on Apple platforms: Mach-O does not support -gz=zlib and AppleClang
+# (which CMAKE_CXX_COMPILER_ID matches as "Clang") would fail the build.
+# The compile flag is scoped to C/C++: -gz is a GCC/Clang host-compiler flag
+# that nvcc does not accept (it would need explicit -Xcompiler forwarding), so
+# applying it directory-wide would break CUDA (ENABLE_GPU) debug builds where
+# gpl marks GPU sources as LANGUAGE CUDA. The link flag needs no such guard:
+# linking is driven by the host C++ compiler.
+if((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+   AND NOT APPLE)
+  set(DEBUG_CONFIG_GENEX "$<OR:$<CONFIG:Debug>,$<CONFIG:RelWithDebInfo>>")
+  add_compile_options(
+    "$<$<AND:${DEBUG_CONFIG_GENEX},$<COMPILE_LANGUAGE:CXX,C>>:-gz=zlib>")
+  add_link_options("$<${DEBUG_CONFIG_GENEX}:-gz=zlib>")
+endif()
+
 # configure a header file to pass some of the CMake settings
 configure_file(
   ${OPENROAD_HOME}/include/ord/Version.hh.cmake

MODULE.bazel

@@ -28,6 +28,12 @@ bazel_dep(name = "platforms", version = "1.0.0")
 bazel_dep(name = "rules_bison", version = "0.3.1")
 bazel_dep(name = "rules_cc", version = "0.2.18")
 bazel_dep(name = "rules_flex", version = "0.3.1")
+
+# rules_go is transitive (or-tools, gazelle, grpc-java, rules_buf). The
+# MVS-selected 0.53.0 references the top-level CcInfo global that Bazel 9
+# removed (go/private/rules/cgo.bzl), breaking analysis. 0.59.0+ loads
+# CcInfo from @rules_cc; force a Bazel-9-compatible release.
+bazel_dep(name = "rules_go", version = "0.61.1")
 bazel_dep(name = "rules_pkg", version = "1.2.0")
 bazel_dep(name = "rules_pycross", version = "0.8.1")
 bazel_dep(name = "rules_python", version = "1.8.5")
@@ -104,6 +110,14 @@ bazel_dep(name = "cudd", version = "3.0.0.bcr.2")
 bazel_dep(name = "eigen", version = "3.4.0.bcr.3")
 bazel_dep(name = "fmt", version = "11.2.0.bcr.1")
 
+# freetype reaches the build transitively (qt-bazel -> harfbuzz -> freetype).
+# freetype@2.13.3's BUILD overlay calls the native cc_library rule, which
+# Bazel 9 removed, so loading the package fails. 2.13.3.bcr.2 keeps the same
+# 2.13.3 source but its overlay loads cc_library from @rules_cc. This is a
+# direct bazel_dep rather than a single_version_override so the pin propagates
+# to downstream consumers via MVS (overrides only apply in the root module).
+bazel_dep(name = "freetype", version = "2.13.3.bcr.2")
+
 # gawk is transitive (abc -> ncurses -> gawk; yosys -> gawk). Same gnulib
 # libc-header shadowing as sed: gawk@5.3.2.bcr.2 fails to compile against
 # hermetic-llvm's explicit libc -isystem entries (BCR #7642). 5.3.2.bcr.7
@@ -114,6 +128,21 @@ single_version_override(
 )
 
 bazel_dep(name = "git", version = "2.54.0")
+
+# We enable the external_include_paths feature globally (see .bazelrc), which
+# demotes a repo's own -iquote entries to -isystem. git relies on -iquote
+# precedence for its quoted includes (builtin/get-tar-commit-id.c includes
+# git's own tar.h, which must shadow glibc's <tar.h>); the patch re-adds the
+# repo root as -iquote in GIT_COPTS so those includes keep precedence.
+single_version_override(
+    module_name = "git",
+    patch_strip = 1,
+    patches = [
+        "//bazel/git-patches:0001-iquote-own-headers-over-external_include_paths.patch",
+    ],
+    version = "2.54.0",
+)
+
 bazel_dep(name = "googletest", version = "1.17.0.bcr.2")
 
 # m4 is transitive (rules_bison/rules_flex -> m4). Same gnulib libc-header
@@ -135,7 +164,10 @@ single_version_override(
     version = "4.9.bcr.5",
 )
 
-bazel_dep(name = "spdlog", version = "1.15.1")
+# spdlog < 1.16.0.bcr.2's BUILD.bazel calls the native cc_test rule, which
+# Bazel 9 removed; loading the package fails. 1.16.0.bcr.2+ loads cc_test
+# from @rules_cc.
+bazel_dep(name = "spdlog", version = "1.17.0")
 bazel_dep(name = "sv-lang", version = "10.0.1-20260316-f04e8156")
 bazel_dep(name = "tcl_lang", version = "9.0.2.bcr.1")
 
@@ -161,9 +193,16 @@ bazel_dep(name = "zlib", version = "1.3.1.bcr.8")
 # allow openroad to link, but will search on the system at runtime for
 # the correct system libs.
 bazel_dep(name = "qt-bazel")
+
+# external_include_paths (see .bazelrc) moves Qt's external-repo include dirs
+# into compilation_context.external_includes. The moc rule at the older pin did
+# not gather those, so moc lost Qt's own header search paths and failed under
+# --config=lint (qtextimagehandler_p.h "Undefined interface", qfilesystemmodel.h
+# "Parse error at QT7_ONLY"). 541ebf6d teaches the moc rule to also collect
+# external_includes.
 git_override(
     module_name = "qt-bazel",
-    commit = "886104974c2fd72439f2c33b5deebf0fe4649df7",
+    commit = "541ebf6df76eef96c4de6343316b1c9d63e296f6",
     remote = "https://github.com/The-OpenROAD-Project/qt_bazel_prebuilts",
 )
 
@@ -179,7 +218,7 @@ bazel_dep(name = "llvm", version = "0.8.11", dev_dependency = True)
 # --- Dev dependencies (not propagated to downstream consumers) ---
 
 bazel_dep(name = "aspect_rules_lint", version = "2.5.2", dev_dependency = True)
-bazel_dep(name = "bant", version = "0.2.10", dev_dependency = True)
+bazel_dep(name = "bant", version = "0.3.0", dev_dependency = True)
 bazel_dep(name = "buildifier_prebuilt", version = "8.5.1.2", dev_dependency = True)
 bazel_dep(name = "rules_verilator", version = "0.1.0", dev_dependency = True)
 bazel_dep(name = "verilator", version = "5.036.bcr.3", dev_dependency = True)
@@ -192,7 +231,7 @@ bazel_dep(name = "rules_nodejs", version = "6.7.3", dev_dependency = True)
 bazel_dep(name = "bazel-orfs", dev_dependency = True)
 bazel_dep(name = "bazel-orfs-verilog", dev_dependency = True)
 
-BAZEL_ORFS_COMMIT = "78f19f25cec73bdec3517a76465dec7ce17ce227"
+BAZEL_ORFS_COMMIT = "551d4c72749411c4b1168c0d12322a9c34817c91"
 
 BAZEL_ORFS_REMOTE = "https://github.com/The-OpenROAD-Project/bazel-orfs.git"
 
@@ -210,27 +249,30 @@ git_override(
     strip_prefix = "verilog",
 )
 
-# bazel-orfs pulls in orfs without a version and patches yosys, relying on
-# overrides that only apply when bazel-orfs is the root module. Mirror them
-# here so OpenROAD-as-root can resolve the module graph.
+# @orfs marks most non-root-only directives (qt-bazel/yosys-slang git_overrides,
+# orfs.default(), toolchain registration) as dev_dependency, so they are no-ops
+# here. But @orfs//flow loads @bazel-orfs//:openroad.bzl, and @orfs marks its
+# bazel-orfs bazel_dep dev_dependency too, which drops @bazel-orfs from @orfs's
+# repo mapping when consumed non-root — so loading @orfs//flow fails. The patch
+# makes that one bazel_dep non-dev.
 #
 # Use archive_override (HTTPS tarball) rather than git_override so the
 # build resolves on networks that block direct git access to github.com.
-ORFS_COMMIT = "10a2baea2171059ec14cda9a5855aa26dd7572c6"
+ORFS_COMMIT = "4b3f2663609fd3f6fd8d862729de1ec5967eb4e6"
 
 bazel_dep(name = "orfs", dev_dependency = True)
 archive_override(
     module_name = "orfs",
     patch_strip = 1,
     patches = [
-        "//bazel/bazel-orfs-patches:0035-fix-remove-non-root-overrides-from-MODULE.bazel.patch",
+        "//bazel/bazel-orfs-patches:0035-orfs-bazel-orfs-visible-non-root.patch",
     ],
-    sha256 = "8325c6755215857a87a84db078d47dfbb2dfcbef70eaf0dd376fe5a7a363cd58",
+    sha256 = "b6e496221b5be5a5ecd54e978a7a8157a212b67374e2ecd6c27f90d35e02b473",
     strip_prefix = "OpenROAD-flow-scripts-" + ORFS_COMMIT,
     urls = ["https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/archive/" + ORFS_COMMIT + ".tar.gz"],
 )
 
-bazel_dep(name = "yosys", version = "0.62.bcr.2", dev_dependency = True)
+bazel_dep(name = "yosys", version = "0.64", dev_dependency = True)
 bazel_dep(name = "yosys-slang", version = "0.0.0", dev_dependency = True)
 archive_override(
     module_name = "yosys-slang",
@@ -377,9 +419,12 @@ single_version_override(
 
 # scip 9.2.3's tinycthread uses bare C11 <threads.h> names. Backport
 # scipopt/scip@cc917e07 (TNY_ prefix) until a fixed release lands in BCR.
+# The .bcr.1 revision keeps the 9.2.3 source (patch still applies) but its
+# overlay BUILD loads cc_library/cc_binary from @rules_cc rather than the
+# native rules Bazel 9 removed.
 single_version_override(
     module_name = "scip",
     patch_strip = 1,
     patches = ["//bazel:scip_tinycthread_tny_prefix.patch"],
-    version = "9.2.3",
+    version = "9.2.3.bcr.1",
 )