Merge branch 'master' of github.com:The-OpenROAD-Project-private/OpenROAD

Author: dsengupta0628

.bazelrc

@@ -120,11 +120,21 @@ build:ci --disk_cache=
 build:ci --config=opt
 
 # Setup remote cache
+# Anon: HTTPS read-only cache
 build --remote_cache=https://bazel.precisioninno.com
 build --remote_cache_compression=true
 build --remote_upload_local_results=false
+# CI: gRPC + Remote Asset API, requires --remote_header
+build:ci --remote_cache=grpcs://bazel.precisioninno.com:443
+build:ci --experimental_remote_downloader=grpcs://bazel.precisioninno.com:443
 
 # Without this, bazelisk build ... builds the bazel-orfs tests
 build --build_tag_filters=-orfs
 
+# clang-tidy via aspect_rules_lint, using clang-tidy from the LLVM toolchain.
+# Usage: bazel build --config=lint //src/utl/...
+build:lint --aspects=//tools/lint:linters.bzl%clang_tidy
+build:lint --output_groups=rules_lint_report
+build:lint --remote_download_outputs=all
+
 try-import %workspace%/user.bazelrc

.github/workflows/github-actions-macos-bazel.yml

@@ -34,8 +34,31 @@ jobs:
         run: brew install bazelisk
 
       - name: Build OpenROAD
+        env:
+          BAZEL_CACHE_PASSWORD: ${{ secrets.BAZEL_CACHE_PASSWORD }}
         run: |
+          # When the secret is present (push / dispatch / private repo PR)
+          # add authed gRPC + Remote Asset API + uploads on top of the
+          # .bazelrc anon HTTPS read-only cache. Fork PRs have no secret
+          # and just use the anon read path.
+          REMOTE_FLAGS=()
+          if [ -n "${BAZEL_CACHE_PASSWORD}" ]; then
+            TOKEN_B64=$(printf 'ci:%s' "${BAZEL_CACHE_PASSWORD}" | base64 | tr -d '\n')
+            # Mask the derived token so it cannot leak in build logs.
+            # GH auto-masks the raw secret but not base64-of-secret.
+            echo "::add-mask::${TOKEN_B64}"
+            REMOTE_FLAGS=(
+              --remote_cache=grpcs://bazel.precisioninno.com:443
+              --experimental_remote_downloader=grpcs://bazel.precisioninno.com:443
+              --remote_upload_local_results=true
+              --remote_header="Authorization=Basic ${TOKEN_B64}"
+            )
+          fi
+          # Trace the bazelisk invocation so we can confirm remote flags are
+          # present. TOKEN_B64 is already masked above, so it prints as ***.
+          set -x
           bazelisk build \
+            "${REMOTE_FLAGS[@]}" \
             --disk_cache=~/.cache/bazel-disk-cache \
             --experimental_disk_cache_gc_max_size=5G \
             --//:platform=gui //:openroad

BUILD.bazel

@@ -38,6 +38,7 @@ config_setting(
 )
 
 exports_files([
+    ".clang-tidy",
     "BUILD.bazel",
     "LICENSE",
     "MODULE.bazel",
@@ -252,11 +253,9 @@ cc_library(
         "include/ord/OpenRoad.hh",
         "include/ord/Tech.h",
         "include/ord/Timing.h",
-        "include/ord/Version.hh",
     ],
     includes = [
         "include",
-        "include/ord",
     ],
     visibility = ["//:__subpackages__"],
     deps = [
@@ -270,6 +269,9 @@ cc_library(
     hdrs = [
         ":OpenRoadVersion",
     ],
+    includes = [
+        "include",
+    ],
 )
 
 genrule(

Jenkinsfile

@@ -1,4 +1,5 @@
 @Library('utils@main') _
-node() {
-    pipelineOR()
+
+k8sPodTemplate(coordinator: true, cloud: utilPickCloud()) {
+    pipelineOR(k8s: true)
 }

MODULE.bazel

@@ -89,6 +89,7 @@ bazel_dep(name = "toolchains_llvm", version = "1.5.0", dev_dependency = True)
 
 # --- Dev dependencies (not propagated to downstream consumers) ---
 
+bazel_dep(name = "aspect_rules_lint", version = "2.5.2", dev_dependency = True)
 bazel_dep(name = "bant", version = "0.2.8", dev_dependency = True)
 bazel_dep(name = "buildifier_prebuilt", version = "8.5.1.2", dev_dependency = True)
 bazel_dep(name = "rules_verilator", version = "0.1.0", dev_dependency = True)
@@ -164,8 +165,7 @@ llvm = use_extension(
 llvm.toolchain(
     llvm_version = "20.1.8",
 )
-use_repo(llvm, "llvm_toolchain")
-# use_repo(llvm, "llvm_toolchain_llvm") # if you depend on specific tools in scripts
+use_repo(llvm, "llvm_toolchain", "llvm_toolchain_llvm")
 
 # FYI: Comment out @llvm_toolchain//:all on NixOS and use the local clang toolchain instead.
 register_toolchains(

MODULE.bazel.lock

@@ -14,6 +14,20 @@ Exit code 8 means some checks are still pending -- not an error.
 ### Clang-Tidy CI
 Clang-Tidy CI can fail not only for code issues but also for **unresolved review comments** on the PR. Review threads cannot be resolved via API on public repos -- must be done on the GitHub web UI.
 
+### Running clang-tidy locally via Bazel
+Run clang-tidy hermetically using the toolchain Bazel already uses to compile:
+```bash
+# Single module:
+bazel build --config=lint //src/utl/...
+
+# Full lint scope (excludes submodules):
+bazel build --config=lint -- //src/... //third-party/... -//src/sta/... -//third-party/abc/...
+```
+- Uses `clang-tidy` from `@llvm_toolchain` (the same binary `etc/run-clang-tidy.sh` uses).
+- Reports land at `$(bazel info bazel-bin)/<pkg>/<target>_rules_lint/<src>.AspectRulesLintClangTidy.out`.
+- Generated files (SWIG, bison, flex) are auto-skipped. Targets tagged `no-lint` are skipped.
+- Aspect + config defined in `tools/lint/` and `//:.bazelrc` (`--config=lint`).
+
 ## CI Artifacts
 
 - Use distinct filenames for public vs private artifacts (never overwrite one with the other)

docs/agents/ci.md

@@ -305,6 +305,23 @@ ln -sf build/compile_commands.json .  # make compilation db visible
 /bin/sh etc/run-clang-tidy-cached.cc
 ```
 
+Alternatively, you can run `clang-tidy` hermetically through Bazel — no
+cmake configuration or Clang Tooling setup is required, and the toolchain
+matches what CI will use:
+
+```shell
+# Single module:
+bazel build --config=lint //src/<module>/...
+
+# Full lint scope (excludes upstream submodules):
+bazel build --config=lint -- //src/... //third-party/... \
+    -//src/sta/... -//third-party/abc/...
+```
+
+Reports land under `bazel-bin/<pkg>/<target>_rules_lint/` as
+`*.AspectRulesLintClangTidy.out` files. Generated files (SWIG, bison, flex)
+and targets tagged `no-lint` are skipped automatically.
+
 ## Doxygen
 
 OpenROAD uses Doxygen style comments to generate documentation.

docs/contrib/DeveloperGuide.md

@@ -103,7 +103,6 @@ To add a new linter (e.g., C++ tidy):
 The following linters and formatters are planned for `//:lint_test` and
 `//:fix_lint`, replacing their ad-hoc CI equivalents:
 
-- **C++ clang-tidy** — static analysis for C++ sources
 - **C++ clang-format** — formatting check/fix for C++ and header files
 - **Python ruff** — lint + format for Python scripts in `etc/`, `docs/`, tests
 - **ShellCheck** — lint for bash scripts in `test/`, `bazel/`, `etc/`
@@ -121,3 +120,9 @@ The GitHub Actions workflow (`.github/workflows/github-actions-lint-tcl.yml`)
 runs the same `tclint` and `tclfmt` checks. Once Bazel lint targets are
 validated in CI, the GitHub Actions workflow can be retired. The same applies
 to the Jenkins documentation and duplicate ID check stages.
+
+C++ clang-tidy is provided via a separate Bazel aspect (`--config=lint`)
+rather than the `//:lint_test` umbrella. Aspects participate in Bazel's
+per-action cache, which the `sh_test`-based umbrella does not, so incremental
+C++ lint scales better that way. See the "Code Linting and Formatting"
+section of `docs/contrib/DeveloperGuide.md` for usage.

docs/contrib/LintTargets.md

@@ -19,6 +19,10 @@
 #include <utility>
 #include <vector>
 
+// Establish abc namespace, must include before abcapis.h
+#include "misc/util/abc_namespaces.h"  // IWYU pragma: keep
+
+// other includes
 #include "annealing_strategy.h"
 #include "base/main/abcapis.h"
 #include "cut/abc_init.h"