Merge branch 'master' of github.com:The-OpenROAD-Project-private/OpenROAD into cts-ndr-spacing-fix

Author: jfgava

.bazelrc

@@ -1,4 +1,10 @@
 common --enable_bzlmod
+# sv-lang 10.0.bcr.2 (slang at f04e8156 with the foreign_cc cmake -xc++
+# fix) is pending upstream as a PR against bazelbuild/bazel-central-
+# registry: https://github.com/bazelbuild/bazel-central-registry/pull/8987
+# Remove this registry line once the version lands on BCR.
+common --registry=https://raw.githubusercontent.com/oharboe/bazel-central-registry/1beaf797951046d93a2f656d4238c954a21833e5/
+common --registry=https://bcr.bazel.build/
 build --workspace_status_command=tools/workspace_status.sh
 
 # Release builds embed real git version info; dev builds use cache-safe placeholders.

.github/workflows/buildifier.yaml

@@ -15,10 +15,15 @@ jobs:
       fail-fast: false
       matrix:
         check:
+          # Drive buildifier from `git ls-files` instead of `-r .` so the
+          # scan stays inside this repo. With `-r .` buildifier was
+          # recursing into submodule contents (third-party/slang-elab/...)
+          # left on disk by self-hosted runners — files we can't fix from
+          # here since they're upstream-managed.
           - name: Buildifier format
-            run: ./buildifier -r -mode=check -lint=off .
+            run: "git ls-files -z ':(glob)**/*.bzl' ':(glob)**/*.bazel' ':(glob)**/BUILD' ':(glob)**/WORKSPACE' | xargs -0 -r ./buildifier -mode=check -lint=off"
           - name: Buildifier lint
-            run: ./buildifier -r -lint=warn .
+            run: "git ls-files -z ':(glob)**/*.bzl' ':(glob)**/*.bazel' ':(glob)**/BUILD' ':(glob)**/WORKSPACE' | xargs -0 -r ./buildifier -lint=warn"
     name: ${{ matrix.check.name }}
     env:
       BUILDIFIER_VERSION: v8.2.1

.github/workflows/github-actions-clang-tidy-bazel.yml

@@ -0,0 +1,102 @@
+name: clang-tidy-bazel
+
+on:
+  pull_request:
+    branches:
+      - master
+
+permissions:
+  contents: read
+  pull-requests: write
+
+jobs:
+  Clang-Tidy-Bazel:
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
+    steps:
+      - name: Check out repository code
+        uses: actions/checkout@v6
+        with:
+          submodules: 'recursive'
+          # Need full history so reviewdog can diff against the PR base.
+          fetch-depth: 0
+
+      - name: Set up bazel
+        # GitHub-hosted ubuntu-latest preinstalls bazelisk, but self-hosted
+        # runners do not. Install it explicitly so the workflow works on
+        # both runner types. bazel-contrib/setup-bazel's default uses a
+        # pre-installed bazelisk; passing bazelisk-version forces install.
+        uses: bazel-contrib/setup-bazel@0.19.0
+        with:
+          bazelisk-version: 1.x
+          bazelisk-cache: true
+
+      - name: Set up reviewdog
+        uses: reviewdog/action-setup@v1
+        with:
+          reviewdog_version: latest
+
+      - name: Run bazel clang-tidy
+        env:
+          BAZEL_CACHE_PASSWORD: ${{ secrets.BAZEL_CACHE_PASSWORD }}
+        run: |
+          # Same auth pattern as github-actions-macos-bazel.yml: when the
+          # cache secret is present (push / dispatch / private repo PR),
+          # add authed gRPC + Remote Asset API on top of the .bazelrc anon
+          # HTTPS read-only cache. Fork PRs have no secret and just read
+          # the anon cache.
+          REMOTE_FLAGS=()
+          if [ -n "${BAZEL_CACHE_PASSWORD}" ]; then
+            TOKEN_B64=$(printf 'ci:%s' "${BAZEL_CACHE_PASSWORD}" | base64 | tr -d '\n')
+            echo "::add-mask::${TOKEN_B64}"
+            REMOTE_FLAGS=(
+              --remote_cache=grpcs://bazel.precisioninno.com:443
+              --experimental_remote_downloader=grpcs://bazel.precisioninno.com:443
+              --remote_upload_local_results=true
+              --remote_header="Authorization=Basic ${TOKEN_B64}"
+            )
+          fi
+          # Note: do NOT use --config=ci here. That config sets
+          # --remote_download_minimal and --config=opt (LTO), but we need
+          # the .AspectRulesLintClangTidy.out files materialized locally
+          # to feed reviewdog, and LTO is wasted work for lint.
+          set -x
+          bazel build \
+            "${REMOTE_FLAGS[@]}" \
+            --config=lint \
+            -- //src/... //third-party/... -//src/sta/... -//third-party/abc/...
+
+      - name: Collect clang-tidy diagnostics
+        run: |
+          # Paths in .out files are sandbox-absolute; strip to workspace-
+          # relative so reviewdog can match against the PR diff. Keep only
+          # `path:line:col: warning|error:` lines — drops source-context
+          # carets, notes, and clang-tidy's header noise in one filter.
+          # `grep -v bazel-out/` drops findings against external virtual
+          # includes (not in any PR diff). `sort -u` dedupes the same
+          # finding emitted under multiple cc_library consumers of a
+          # shared source.
+          BAZEL_BIN=$(bazel info bazel-bin)
+          find "${BAZEL_BIN}" -name '*.AspectRulesLintClangTidy.out' -print0 \
+            | xargs -0 cat \
+            | sed -E 's|^.*/execroot/_main/||' \
+            | grep -E '^[^:]+:[0-9]+:[0-9]+: (warning|error):' \
+            | grep -vE '^(bazel-out|external)/' \
+            | sort -u \
+            > clang-tidy.txt
+          echo "::group::clang-tidy.txt (head)"
+          head -50 clang-tidy.txt || true
+          echo "::endgroup::"
+          echo "Findings: $(wc -l < clang-tidy.txt)"
+
+      - name: Run reviewdog
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          reviewdog \
+            -efm="%E%f:%l:%c: error: %m" \
+            -efm="%W%f:%l:%c: warning: %m" \
+            -name="clang-tidy" \
+            -reporter=github-pr-review \
+            -filter-mode=added \
+            -fail-level=any \
+            < clang-tidy.txt

.github/workflows/github-actions-clang-tidy-post.yml

@@ -8,7 +8,6 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")
 load("@rules_python//python:defs.bzl", "py_library")
 load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
 load("@rules_shell//shell:sh_test.bzl", "sh_test")
-load("//bazel:notification.bzl", "notification_rule")
 load("//bazel:python_wrap_cc.bzl", "PYTHON_EXTENSION_LINKOPTS", "PYTHON_STABLE_API_DEFINE", "python_wrap_cc")
 load("//bazel:tcl_encode_or.bzl", "tcl_encode")
 load("//bazel:tcl_wrap_cc.bzl", "tcl_wrap_cc")
@@ -22,22 +21,6 @@ package(
     ],
 )
 
-# Notification target to notify user if --config=opt (with LTO) is not used.
-notification_rule(
-    name = "opt_notification",
-    is_opt = select(
-        {
-            ":lto_on": True,
-            "//conditions:default": False,
-        },
-    ),
-)
-
-config_setting(
-    name = "lto_on",
-    values = {"copt": "-flto"},
-)
-
 exports_files([
     ".clang-tidy",
     "BUILD.bazel",
@@ -196,7 +179,6 @@ cc_library(
 # include needs to see.
 OPENROAD_MAIN_DEPS = [
     ":openroad_version",
-    ":opt_notification",
     ":ord",
     ":tcl_readline_setup",
     "//bazel:tcl_library_init",

.github/workflows/github-actions-clang-tidy.yml

@@ -26,6 +26,9 @@ if echo "$fromImage" | grep -q "ubuntu"; then
 else
     echo "Skipping strip command as fromImage does not contain 'ubuntu'"
 fi
+if command -v apt-get >/dev/null 2>&1; then
+    rm -rf /var/lib/apt/lists/*
+fi
 rm -f /tmp/DependencyInstaller.sh
 EOF
 

BUILD.bazel

@@ -16,6 +16,7 @@ bazel_dep(name = "rules_bison", version = "0.3.1")
 bazel_dep(name = "rules_cc", version = "0.2.18")
 bazel_dep(name = "rules_flex", version = "0.3.1")
 bazel_dep(name = "rules_pkg", version = "1.2.0")
+bazel_dep(name = "rules_pycross", version = "0.8.1")
 bazel_dep(name = "rules_python", version = "1.8.5")
 bazel_dep(name = "rules_shell", version = "0.6.1")
 bazel_dep(name = "swig", version = "4.3.0.bcr.2")
@@ -61,10 +62,12 @@ bazel_dep(name = "boost.unordered", version = BOOST_VERSION)
 bazel_dep(name = "boost.utility", version = BOOST_VERSION)
 bazel_dep(name = "cudd", version = "3.0.0.bcr.2")
 bazel_dep(name = "eigen", version = "3.4.0.bcr.3")
+bazel_dep(name = "fmt", version = "11.2.0.bcr.1")
 bazel_dep(name = "googletest", version = "1.17.0.bcr.2")
 bazel_dep(name = "openmp", version = "21.1.5.bcr.1")
 bazel_dep(name = "or-tools", version = "9.15")
 bazel_dep(name = "spdlog", version = "1.15.1")
+bazel_dep(name = "sv-lang", version = "10.0.bcr.2")
 bazel_dep(name = "tcl_lang", version = "9.0.2.bcr.1")
 bazel_dep(name = "tcmalloc", version = "0.0.0-20250927-12f2552")
 bazel_dep(name = "yaml-cpp", version = "0.9.0")
@@ -89,7 +92,7 @@ bazel_dep(name = "toolchains_llvm", version = "1.5.0", dev_dependency = True)
 # --- Dev dependencies (not propagated to downstream consumers) ---
 
 bazel_dep(name = "aspect_rules_lint", version = "2.5.2", dev_dependency = True)
-bazel_dep(name = "bant", version = "0.2.9", dev_dependency = True)
+bazel_dep(name = "bant", version = "0.2.10", dev_dependency = True)
 bazel_dep(name = "buildifier_prebuilt", version = "8.5.1.2", dev_dependency = True)
 bazel_dep(name = "rules_verilator", version = "0.1.0", dev_dependency = True)
 bazel_dep(name = "verilator", version = "5.036.bcr.3", dev_dependency = True)
@@ -188,6 +191,13 @@ pip.parse(
 )
 use_repo(pip, "openroad-pip")
 
+# sv-lang pulls in rules_pycross, whose toolchain extension fails on Python
+# 3.8 (transitively registered via or-tools -> pybind11_abseil, dropped
+# from rules_python 2.0.0's MINOR_MAPPING). pycross.configure_environments
+# is root-honored only, so the workaround lives here.
+pycross = use_extension("@rules_pycross//pycross/extensions:pycross.bzl", "pycross")
+pycross.configure_environments(python_versions = ["3.13"])
+
 node = use_extension(
     "@rules_nodejs//nodejs:extensions.bzl",
     "node",
@@ -217,18 +227,21 @@ orfs.default(
 
 # --- External archives ---
 
+# Alias @slang -> @sv-lang//:libsvlang so submodule BUILD files that
+# reference @slang resolve without modification. OpenROAD source uses
+# @sv-lang directly; this alias only exists for the slang-elab submodule.
 new_local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "new_local_repository")
 
 new_local_repository(
-    name = "fmt",
-    build_file = "//third-party/slang-elab/third_party:fmt.BUILD",
-    path = "third-party/slang-elab/third_party/fmt",
-)
-
-new_local_repository(
     name = "slang",
-    build_file = "//third-party/slang-elab/third_party:slang.BUILD",
-    path = "third-party/slang-elab/third_party/slang",
+    build_file_content = """\
+alias(
+    name = "slang",
+    actual = "@sv-lang//:libsvlang",
+    visibility = ["//visibility:public"],
+)
+""",
+    path = "bazel",
 )
 
 # --- Overrides ---