Merge pull request #10708 from naveenvenk17/nv-bazel-gpl-fft-layering-10478

bazel: enable layering check for gpl fft test

Author: maliberty

src/gpl/BUILD

@@ -14,19 +14,23 @@ package(
     features = ["layering_check"],
 )
 
-# Headers owned by :gpl but also consumed by :ui. Kept package-private so
-# nothing outside //src/gpl can depend on them.
+# Headers owned by :gpl but also consumed by :ui and GPL tests. Keep them
+# visible only to //src/gpl and its tests.
 cc_library(
     name = "gpl_private_hdrs",
     hdrs = [
+        "src/fft.h",
         "src/nesterovBase.h",
         "src/nesterovPlace.h",
         "src/placerBase.h",
         "src/point.h",
         "src/routeBase.h",
     ],
     includes = ["src"],
-    visibility = ["//visibility:private"],
+    visibility = [
+        "//src/gpl/test:__pkg__",
+        "//visibility:private",
+    ],
     deps = [
         "//src/odb/src/db",
         "//src/utl",
@@ -44,7 +48,6 @@ cc_library(
         "src/densityGradient.cpp",
         "src/densityGradientBackend.h",
         "src/fft.cpp",
-        "src/fft.h",
         "src/fftBackend.h",
         "src/fftsg.cpp",
         "src/fftsg2d.cpp",

src/gpl/test/BUILD

@@ -144,10 +144,10 @@ PY_TESTS = [
 cc_test(
     name = "gpl_fft_unittest",
     srcs = ["fft_test.cc"],
-    features = ["-layering_check"],  # TODO: includes private headers
     linkstatic = True,  # TODO: remove once deps define all symbols
     deps = [
         "//src/gpl",
+        "//src/gpl:gpl_private_hdrs",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
         "@spdlog",