Merge pull request #10206 from The-OpenROAD-Project-staging/update_or_sta_upstream0416_plus_my_test

update STA 4/20 and associated changes

Author: maliberty

src/Timing.cc

@@ -458,9 +458,7 @@ std::vector<ClockInfo> Timing::getClockInfo()
     ClockInfo info;
     info.name = clk->name();
     info.period = clk->period();
-    if (clk->waveform()) {
-      info.waveform = *clk->waveform();
-    }
+    info.waveform = clk->waveform();
     for (const sta::Pin* pin : clk->pins()) {
       auto [iterm, bterm] = staToDBPin(pin);
       if (iterm) {

src/cut/test/cpp/TestAbc.cc

@@ -99,14 +99,14 @@ class AbcTest : public tst::Fixture
     sta::Port* clk_port = network->findPort(top_cell, "clk");
     sta::Pin* clk_pin = network->findPin(network->topInstance(), clk_port);
 
-    sta::PinSet* pinset = new sta::PinSet(network);
-    pinset->insert(clk_pin);
+    sta::PinSet pinset(network);
+    pinset.insert(clk_pin);
 
     // 0.5ns
     double period = sta_->units()->timeUnit()->userToSta(0.5);
-    sta::FloatSeq* waveform = new sta::FloatSeq;
-    waveform->push_back(0);
-    waveform->push_back(period / 2.0);
+    sta::FloatSeq waveform;
+    waveform.push_back(0);
+    waveform.push_back(period / 2.0);
 
     sta_->makeClock("core_clock",
                     pinset,

src/rmp/test/cpp/TestAbc.cc

@@ -91,14 +91,14 @@ class AbcTest : public tst::Fixture
     sta::Port* clk_port = network->findPort(top_cell, "clk");
     sta::Pin* clk_pin = network->findPin(network->topInstance(), clk_port);
 
-    sta::PinSet* pinset = new sta::PinSet(network);
-    pinset->insert(clk_pin);
+    sta::PinSet pinset(network);
+    pinset.insert(clk_pin);
 
     // 0.5ns
     double period = sta_->units()->timeUnit()->userToSta(0.5);
-    sta::FloatSeq* waveform = new sta::FloatSeq;
-    waveform->push_back(0);
-    waveform->push_back(period / 2.0);
+    sta::FloatSeq waveform;
+    waveform.push_back(0);
+    waveform.push_back(period / 2.0);
 
     sta_->makeClock("core_clock",
                     pinset,

src/rsz/src/Resizer.cc

@@ -78,6 +78,7 @@
 #include "sta/PortDirection.hh"
 #include "sta/Scene.hh"
 #include "sta/Sdc.hh"
+#include "sta/SdcClass.hh"
 #include "sta/Search.hh"
 #include "sta/SearchPred.hh"
 #include "sta/StringUtil.hh"
@@ -1225,7 +1226,7 @@ float Resizer::driveResistance(const sta::Pin* drvr_pin)
         for (auto rf : sta::RiseFall::range()) {
           const sta::LibertyCell* cell;
           const sta::LibertyPort* from_port;
-          float* from_slews;
+          const sta::DriveCellSlews* from_slews;
           const sta::LibertyPort* to_port;
           drive->driveCell(rf, min_max, cell, from_port, from_slews, to_port);
           if (to_port) {

src/sta

@@ -105,18 +105,14 @@ void IntegratedFixture::initStaDefaultSdc()
     sta::Pin* clk_pin
         = db_network_->findPin(db_network_->topInstance(), clk_port);
 
-    // STA frees the 'clk_pins' after use.
-    // coverity[RESOURCE_LEAK: FALSE_POSITIVE]
-    sta::PinSet* clk_pins = new sta::PinSet(db_network_);
-    clk_pins->insert(clk_pin);
+    sta::PinSet clk_pins(db_network_);
+    clk_pins.insert(clk_pin);
 
     // Clock period = 0.5ns
     double period = sta_->units()->timeUnit()->userToSta(0.5);
-    // STA takes the ownership of 'waveform'.
-    // coverity[RESOURCE_LEAK: FALSE_POSITIVE]
-    sta::FloatSeq* waveform = new sta::FloatSeq;
-    waveform->push_back(0);
-    waveform->push_back(period / 2.0);
+    sta::FloatSeq waveform;
+    waveform.push_back(0);
+    waveform.push_back(period / 2.0);
 
     sta_->makeClock("clk",
                     clk_pins,