Merge pull request #10722 from Fermions-ASI/fix/10490

pdn: prevent pad connections from targeting macro grid shapes (#10490)

Author: gadfort

src/pdn/src/straps.cpp

@@ -1590,6 +1590,19 @@ bool PadDirectConnectionStraps::refineShape(
 
 bool PadDirectConnectionStraps::isTargetShape(const Shape* shape) const
 {
+  // Pad direct connections run from a pad pin toward the core power grid.  They
+  // must not target shapes that belong to an instance (macro) grid: those
+  // stripes sit inside the core over the macro, and snapping a pad connection
+  // to them drags the connection deep into the core (issue #10490).  Only
+  // shapes owned by core/existing grids are valid landing targets.
+  const auto* component = shape->getGridComponent();
+  if (component != nullptr) {
+    const auto* grid = component->getGrid();
+    if (grid != nullptr && grid->type() == Grid::kInstance) {
+      return false;
+    }
+  }
+
   if (target_shapes_type_) {
     return shape->getType() == target_shapes_type_.value();
   }

src/pdn/test/BUILD

@@ -117,6 +117,7 @@ COMPULSORY_TESTS = [
     "pads_black_parrot_flipchip_connect_overpads",
     "pads_black_parrot_grid_define",
     "pads_black_parrot_limit_connect",
+    "pads_black_parrot_macro_grid",
     "pads_black_parrot_max_width",
     "pads_black_parrot_no_connect",
     "pads_black_parrot_offset",

src/pdn/test/CMakeLists.txt

@@ -113,6 +113,7 @@ or_integration_tests(
     pads_black_parrot_flipchip_connect_overpads
     pads_black_parrot_grid_define
     pads_black_parrot_limit_connect
+    pads_black_parrot_macro_grid
     pads_black_parrot_max_width
     pads_black_parrot_no_connect
     pads_black_parrot_offset