Merge pull request #10116 from oharboe/install-fix

bazel: fix installed binary Tcl init failure

Author: maliberty

bazel/install.sh

@@ -18,6 +18,5 @@ if [ -e openroad.repo_mapping ]; then
     chmod u+w openroad.repo_mapping
     rm -rf openroad.repo_mapping
 fi
-rm -rf openroad.runfiles/_main
 
 echo "OpenROAD binary installed to $(realpath "$DEST_DIR")"

packaging/BUILD.bazel

@@ -15,4 +15,5 @@ pkg_tar(
     srcs = ["//:openroad"],
     include_runfiles = True,
     package_file_name = "openroad.tar",
+    visibility = ["//test:__subpackages__"],
 )

test/install/BUILD.bazel

@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2026, The OpenROAD Authors
+
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
+
+sh_test(
+    name = "install_test",
+    srcs = ["install_test.sh"],
+    args = ["$(rootpath //packaging:tarfile)"],
+    data = ["//packaging:tarfile"],
+    tags = ["local"],
+)

test/install/README.md

@@ -0,0 +1,26 @@
+# Install smoke test
+
+Verifies that the binary produced by `//packaging:tarfile` starts correctly
+after extraction (Tcl initialisation, runfiles resolution, etc.).
+
+## Running
+
+```sh
+bazelisk test //test/install/...
+```
+
+## What it checks
+
+1. Extracts the packaging tarball into a temporary directory (same layout
+   that `bazelisk run //packaging:install` produces).
+2. Launches the binary with a trivial Tcl script (`puts "install_test_ok"`).
+3. Asserts the expected output appears, proving Tcl initialised and the
+   interpreter is functional.
+
+## Background
+
+The installed binary relies on Bazel runfiles for Tcl library files
+(`init.tcl`, tclreadline, etc.).  These live under
+`openroad.runfiles/_main/bazel/tcl_resources_dir/`.  If the runfiles
+tree is damaged during packaging or installation the binary fails with
+`application-specific initialization failed:` (GitHub issue #10115).

test/install/install_test.sh

@@ -0,0 +1,37 @@
+#!/usr/bin/env bash
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2026, The OpenROAD Authors
+#
+# Smoke test: extract the packaging tarball and verify the installed
+# binary can start (Tcl initialisation succeeds).
+set -euo pipefail
+
+TARFILE="$1"
+
+DEST_DIR=$(mktemp -d)
+trap 'rm -rf "$DEST_DIR"' EXIT
+
+cp "$TARFILE" "$DEST_DIR"
+cd "$DEST_DIR"
+tar -xf openroad.tar
+rm -f openroad.tar
+
+# Remove repo_mapping (same as install.sh)
+if [ -e openroad.repo_mapping ]; then
+    chmod u+w openroad.repo_mapping
+    rm -rf openroad.repo_mapping
+fi
+
+# Clear Bazel runfiles env vars so the installed binary resolves its own
+# runfiles tree (not the test runner's).
+unset RUNFILES_DIR RUNFILES_MANIFEST_FILE TEST_SRCDIR
+
+# Verify the binary starts and can evaluate a trivial Tcl expression.
+echo 'puts "install_test_ok"' > test_script.tcl
+if OUTPUT=$(./openroad -no_init -no_splash -exit test_script.tcl 2>&1) && echo "$OUTPUT" | grep -q "install_test_ok"; then
+    echo "PASS: installed binary started successfully"
+else
+    echo "FAIL: installed binary failed to start or produced unexpected output"
+    echo "Output was: $OUTPUT"
+    exit 1
+fi