Skip to content

Commit d603263

Browse files
committed
Add missing dependency and document a cyclic dependency.
backend_builder.h includes * `slang/ast/expressions/Operator.h` so needs to depend on `@slang` * `slang_frontend.h` so needs to depend on `//third-party/slang-elab/src:slang_frontend`, but that creates a cyclic dependency. This should be properly layered and fixed. Signed-off-by: Henner Zeller <h.zeller@acm.org>
1 parent 9f8ff00 commit d603263

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

src/syn/src/elab/BUILD

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ cc_library(
2020
visibility = ["//visibility:public"],
2121
deps = [
2222
"//src/syn/src/ir",
23+
# TODO: backend_builder.h includes slang_frontend.h, so we need
24+
# :slang_frontend, but that indirectly depends on this, creating cycle.
25+
# So can't add the following dependency right now.
26+
#"//third-party/slang-elab/src:slang_frontend",
27+
"@slang",
2328
],
2429
)
2530

0 commit comments

Comments
 (0)