Merge pull request #10195 from The-OpenROAD-Project-staging/tap-tidy-naming

tap: adjust naming to Google-style (excluding method names)

Author: maliberty

src/gui/src/search.h

@@ -67,7 +67,7 @@ class Search : public QObject, public odb::dbBlockCallBackObj
   template <typename T>
   struct BBoxIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(T t) const { return t->getBBox()->getBox(); }
     odb::Rect operator()(const SNetValue<T>& t) const
     {
@@ -85,7 +85,7 @@ class Search : public QObject, public odb::dbBlockCallBackObj
 
   struct FillIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(odb::dbFill* t) const
     {
       odb::Rect fill;

src/pdn/src/power_cells.h

@@ -119,7 +119,7 @@ class GridSwitchedPower
 
   struct InstIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(odb::dbInst* inst) const
     {
       return inst->getBBox()->getBox();
@@ -136,7 +136,7 @@ class GridSwitchedPower
 
   struct RowIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(odb::dbRow* row) const { return row->getBBox(); }
   };
   using RowTree

src/pdn/src/shape.h

@@ -60,12 +60,12 @@ class Shape
   };
   struct RectIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(const ShapePtr& t) const { return t->getRect(); }
   };
   struct ObstructionIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(const ShapePtr& t) const
     {
       return t->getObstruction();

src/pdn/src/via.h

@@ -717,7 +717,7 @@ class Via
  public:
   struct ViaIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(const ViaPtr& via) const { return via->getArea(); }
   };
   using ViaTree = bgi::rtree<ViaPtr, bgi::quadratic<16>, ViaIndexableGetter>;

src/psm/src/ir_network.h

@@ -25,14 +25,14 @@ namespace psm {
 template <typename T>
 struct RectIndexableGetter
 {
-  using result_type = odb::Rect;
+  using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
   odb::Rect operator()(const T* t) const { return t->getShape(); }
 };
 
 template <typename T>
 struct PointIndexableGetter
 {
-  using result_type = odb::Point;
+  using result_type = odb::Point;  // NOLINT(readability-identifier-naming)
   odb::Point operator()(const T* t) const { return t->getPoint(); }
 };
 

src/tap/include/tap/tapcell.h

@@ -100,11 +100,11 @@ class Tapcell
  private:
   enum class EdgeType
   {
-    Left,
-    Top,
-    Right,
-    Bottom,
-    Unknown
+    kLeft,
+    kTop,
+    kRight,
+    kBottom,
+    kUnknown
   };
   struct Edge
   {
@@ -115,15 +115,15 @@ class Tapcell
   };
   enum class CornerType
   {
-    OuterBottomLeft,
-    OuterTopLeft,
-    OuterTopRight,
-    OuterBottomRight,
-    InnerBottomLeft,
-    InnerTopLeft,
-    InnerTopRight,
-    InnerBottomRight,
-    Unknown
+    kOuterBottomLeft,
+    kOuterTopLeft,
+    kOuterTopRight,
+    kOuterBottomRight,
+    kInnerBottomLeft,
+    kInnerTopLeft,
+    kInnerTopRight,
+    kInnerBottomRight,
+    kUnknown
   };
   struct PartialOverlap
   {
@@ -143,7 +143,7 @@ class Tapcell
 
   struct InstIndexableGetter
   {
-    using result_type = odb::Rect;
+    using result_type = odb::Rect;  // NOLINT(readability-identifier-naming)
     odb::Rect operator()(odb::dbInst* inst) const
     {
       return inst->getBBox()->getBox();