Skip to content

Commit e0dc9d2

Browse files
committed
test uses private headers: make available and depend on them.
But also, we do need to depend on drt as well, as we're using symbols defined there without including any of the headers. So mark as `keep` for now, so that we don't remove it. Signed-off-by: Henner Zeller <h.zeller@acm.org>
1 parent 5809d12 commit e0dc9d2

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/drt/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ cc_library(
129129
"src/ta/FlexTA.h",
130130
],
131131
includes = ["src"],
132-
visibility = ["//visibility:private"],
132+
visibility = ["//src/drt/test:__pkg__"],
133133
deps = [
134134
":base_types",
135135
":db_hdrs",

src/drt/test/BUILD

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,14 @@ cc_test(
162162
"fixture.h",
163163
"gcTest.cpp",
164164
],
165-
features = ["-layering_check"], # TODO: acceses private headers
166165
includes = [
167166
"../src",
168167
],
169168
deps = [
170169
"//src/drt", # build_cleaner: keep for private headers
171170
"//src/drt:base_types",
172171
"//src/drt:db_hdrs",
172+
"//src/drt:drt_private_hdrs",
173173
"//src/odb/src/db",
174174
"//src/utl",
175175
"@googletest//:gtest",
@@ -189,14 +189,15 @@ cc_test(
189189
"fixture.h",
190190
"taTest.cpp",
191191
],
192-
features = ["-layering_check"], # TODO: acceses private headers
193192
includes = [
194193
"../src",
195194
],
196195
deps = [
197-
"//src/drt",
196+
# drt only exports header TritonRoute.h, but we need other symbols
197+
"//src/drt", # build_cleaner: keep
198198
"//src/drt:base_types",
199199
"//src/drt:db_hdrs",
200+
"//src/drt:drt_private_hdrs",
200201
"//src/odb/src/db",
201202
"//src/utl",
202203
"@googletest//:gtest",

0 commit comments

Comments
 (0)