Update Web GUI and odb tests

Signed-off-by: Jorge Ferreira <jorge.ferreira@precisioninno.com>

Author: jorge-ferreira-pii

src/OpenRoad.tcl

@@ -236,21 +236,6 @@ proc check_3dblox { args } {
   ord::check_3dblox_cmd
 }
 
-sta::define_cmd_args "clear_3dbx" {}
-
-proc clear_3dbx { args } {
-  sta::parse_key_args "clear_3dbx" args keys {} flags {}
-  sta::check_argc_eq0 "clear_3dbx" $args
-  # read_3dbx creates one dbChip per chiplet (CPU/MEM/…) plus one HIER
-  # chip for the assembly. Destroying only the top chip leaves the
-  # chiplet defs behind and the next read_3dbx errors with "Chiplet X
-  # already exists". Snapshot the set first because destroy mutates it.
-  set db [ord::get_db]
-  set chips [list]
-  foreach c [$db getChips] { lappend chips $c }
-  foreach c $chips { odb::dbChip_destroy $c }
-}
-
 sta::define_cmd_args "write_db" {filename}
 
 sta::define_cmd_args "read_db" {[-hier] filename}

src/odb/test/BUILD

@@ -151,7 +151,6 @@ COMPULSORY_TESTS = [
     "bterm_hier_create",
     "check_3dblox",
     "check_routing_tracks",
-    "clear_3dbx",
     "create_blockage",
     "create_obstruction",
     "create_sboxes",

src/odb/test/CMakeLists.txt

@@ -7,7 +7,6 @@ or_integration_tests(
     bterm_hier_create
     check_3dblox
     check_routing_tracks
-    clear_3dbx
     create_blockage
     create_obstruction
     create_sboxes

src/odb/test/clear_3dbx.ok

@@ -1,8 +1,8 @@
 GUI 0019 web.tcl:119               Display option must have 2 elements {control name} {value}. ERROR https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web.tcl#L119
-WEB 0001 web_serve.cpp:227         Server started on {}. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L227
-WEB 0002 web_serve.cpp:231         Server error : {} ERROR https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L231
-WEB 0004 web_serve.cpp:166         Serving static files from {} INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L166
-WEB 0006 web_serve.cpp:110         Web server is already running. WARN https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L110
+WEB 0001 web_serve.cpp:199         Server started on {}. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L199
+WEB 0002 web_serve.cpp:203         Server error : {} ERROR https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L203
+WEB 0004 web_serve.cpp:167         Serving static files from {} INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L167
+WEB 0006 web_serve.cpp:111         Web server is already running. WARN https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L111
 WEB 0010 web.cpp:1121              Failed to open acceptor: {} ERROR https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web.cpp#L1121
 WEB 0011 web.cpp:1126              Failed to set reuse_address option: {} ERROR https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web.cpp#L1126
 WEB 0017 web.cpp:1132              Failed to bind to endpoint: {} ERROR https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web.cpp#L1132
@@ -24,5 +24,5 @@ WEB 0032 web.cpp:1470              Saved timing report to {} INFO https://github
 WEB 0033 web.cpp:1340              Cached {} tiles at zoom {}. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web.cpp#L1340
 WEB 0034 web.cpp:1364              Rendered {} setup + {} hold path overlays. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web.cpp#L1364
 WEB 0035 web.cpp:1256              No design loaded. ERROR https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web.cpp#L1256
-WEB 0040 request_handler.cpp:1361  Exit requested from web GUI; shutting down. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/request_handler.cpp#L1361
-WEB 0041 web_serve.cpp:285         Web session closed. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L285
+WEB 0040 request_handler.cpp:1362  Exit requested from web GUI; shutting down. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/request_handler.cpp#L1362
+WEB 0041 web_serve.cpp:257         Web session closed. INFO https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/workspace/teste/OpenROAD-flow-scripts/tools/OpenROAD/src/web/src/web_serve.cpp#L257

src/odb/test/clear_3dbx.tcl

@@ -186,44 +186,15 @@ void WebServer::serve(int port, const std::string& doc_root)
       threads_.emplace_back([this] { ioc_->run(); });
     }
 
-    // Prefer Chromium app mode: --app=URL opens a standalone window
-    // that JS can close via window.close(). A regular xdg-open tab
-    // cannot be closed from JS, so `exit` in the web console would
-    // leave the tab orphaned.
-    bool launched = false;
 #if defined(__APPLE__)
-    launched = std::system(("open -na 'Google Chrome' --args --app=" + url
-                            + " > /dev/null 2>&1")
-                               .c_str())
-               == 0;
-#elif !defined(_WIN32)
-    static const char* kAppBrowsers[] = {"google-chrome",
-                                         "google-chrome-stable",
-                                         "chromium",
-                                         "chromium-browser",
-                                         "microsoft-edge",
-                                         "brave-browser"};
-    for (const char* browser : kAppBrowsers) {
-      const std::string check
-          = std::string("command -v ") + browser + " > /dev/null 2>&1";
-      if (std::system(check.c_str()) == 0) {
-        std::system(
-            (std::string(browser) + " --app=" + url + " > /dev/null 2>&1 &")
-                .c_str());
-        launched = true;
-        break;
-      }
-    }
-#endif
-    if (!launched) {
-#if defined(__APPLE__)
-      std::system(("open " + url + " > /dev/null 2>&1").c_str());
+    std::string open_cmd = "open " + url + " > /dev/null 2>&1";
 #elif defined(_WIN32)
-      std::system(("start " + url + " > nul 2>&1").c_str());
+    std::string open_cmd = "start " + url + " > nul 2>&1";
 #else
-      std::system(("xdg-open " + url + " > /dev/null 2>&1 &").c_str());
+    std::string open_cmd = "xdg-open " + url + " > /dev/null 2>&1 &";
 #endif
-    }
+    int ret = std::system(open_cmd.c_str());
+    (void) ret;
 
     logger_->info(utl::WEB, 1, "Server started on {}.", url);