Skip to content

Commit e89327a

Browse files
etc/Build.sh: drop dead isNinja block to fix unbound variable
The isNinja branch was never reachable (no code path sets it) and under 'set -euo pipefail' it terminated the script with 'isNinja: unbound variable' at line 358 once master's removal of the ninja option (commit 4e494df) was merged in. Remove the dead block. Reported by maliberty in #9762. Signed-off-by: alokkumardalei-wq <alokkumardalei2@gmail.com>
1 parent e8ea5ba commit e89327a

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

etc/Build.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -355,11 +355,5 @@ if [[ "$useBazel" == "yes" ]]; then
355355
"${bazel_cmd}" build "${bazelArgs[@]}" //:openroad
356356
exit 0
357357
fi
358-
if [[ "$isNinja" == "yes" ]]; then
359-
cmake "${cmakeOptions[@]}" -B "${buildDir}" .
360-
cd "${buildDir}"
361-
CLICOLOR_FORCE=1 ninja build_and_test
362-
exit 0
363-
fi
364358
cmake "${cmakeOptions[@]}" -B "${buildDir}" .
365359
time cmake --build "${buildDir}" -j "${numThreads}"

0 commit comments

Comments
 (0)