Skip to content

Commit f350101

Browse files
committed
docs: clarify linter is planned and fix test registration paths
Address PR review feedback: mark the binding-coverage linter as a not-yet-implemented future tool, and reference the module-specific src/<module>/test/ paths for CMake/Bazel registration. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
1 parent d3108e7 commit f350101

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

docs/agents/testing-strategy.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,9 @@ The existing fixture stack already supports this:
131131
`PASSFAIL_TESTS` where possible.
132132
- Treat the C++ test as the source of truth for correctness; bindings prove
133133
plumbing only. Do **not** duplicate algorithm assertions across Tcl + Python.
134-
- A linter can enumerate public commands from the `.tcl`/`.i` files and flag any
135-
without a smoke test, guaranteeing binding coverage without hand-curation.
134+
- A future linter (not yet implemented) could enumerate public commands from the
135+
`.tcl`/`.i` files and flag any without a smoke test, guaranteeing binding
136+
coverage without hand-curation.
136137

137138
## Decision tree for a new test
138139

@@ -182,9 +183,9 @@ at once.
182183
6. **Delete the superseded Tcl/Python test(s) and their artifacts, and
183184
de-register from BOTH build systems** -- in this same change. Remove the
184185
`.tcl`/`.py` and its `.ok`/`.defok`/`.vok`; drop the name from
185-
`test/CMakeLists.txt` (`or_integration_tests`) **and** `test/BUILD`
186-
(`regression_test`). Remove checked-in DEF/LEF data only if nothing else
187-
references it (grep first -- fixtures like Nangate45 and shared `data/` files
186+
`src/<module>/test/CMakeLists.txt` (`or_integration_tests`) **and**
187+
`src/<module>/test/BUILD` (`regression_test`). Remove checked-in DEF/LEF data
188+
only if nothing else references it (grep first -- fixtures like Nangate45 and shared `data/` files
188189
are used by many tests).
189190
7. **Check residual binding coverage.** Removing a *golden* test does not have to
190191
mean the command loses all Tcl/Python exercise: a command is often also

0 commit comments

Comments
 (0)