Merge branch 'master' of https://github.com/The-OpenROAD-Project/OpenROAD into gpl-virtual-cts

Author: eder-matheus

.bazelrc

@@ -5,6 +5,10 @@ common --enable_bzlmod
 # Remove this registry line once the version lands on BCR.
 common --registry=https://raw.githubusercontent.com/oharboe/bazel-central-registry/1beaf797951046d93a2f656d4238c954a21833e5/
 common --registry=https://bcr.bazel.build/
+
+# abc is driven programmatically by OpenROAD, so skip the interactive
+# readline dependency exposed by abc@0.64-yosyshq.bcr.2.
+common --@abc//:use_readline=false
 build --workspace_status_command=tools/workspace_status.sh
 
 # Release builds embed real git version info; dev builds use cache-safe placeholders.
@@ -46,6 +50,16 @@ build  --cxxopt=-fexceptions    --host_cxxopt=-fexceptions
 build --copt "-Wall"               --host_copt "-Wall"
 build --copt "-Wextra"             --host_copt "-Wextra"
 
+# Treat specific warnings as errors
+build --copt "-Werror=array-bounds"               --host_copt "-Werror=array-bounds"
+build --copt "-Werror=dangling"                   --host_copt "-Werror=dangling"
+build --copt "-Werror=dangling-assignment"        --host_copt "-Werror=dangling-assignment"
+build --copt "-Werror=dangling-assignment-gsl"    --host_copt "-Werror=dangling-assignment-gsl"
+build --copt "-Werror=dangling-field"             --host_copt "-Werror=dangling-field"
+build --copt "-Werror=dangling-gsl"               --host_copt "-Werror=dangling-gsl"
+build --copt "-Werror=fortify-source"             --host_copt "-Werror=fortify-source"
+build --copt "-Werror=return-stack-address"       --host_copt "-Werror=return-stack-address"
+
 # ... and disable the warnings we're not interested in.
 build --copt "-Wno-sign-compare"          --host_copt "-Wno-sign-compare"
 build --copt "-Wno-unused-parameter"      --host_copt "-Wno-unused-parameter"
@@ -69,7 +83,6 @@ build --copt "-Wno-cast-function-type-mismatch"  --host_copt "-Wno-cast-function
 build --copt "-Wno-unused-but-set-variable"  --host_copt "-Wno-unused-but-set-variable"
 build --cxxopt "-Wno-deprecated-copy"  --host_cxxopt "-Wno-deprecated-copy"
 build --cxxopt "-Wno-deprecated-copy-with-user-provided-copy"  --host_cxxopt "-Wno-deprecated-copy-with-user-provided-copy"
-build --cxxopt "-Wno-dangling"  --host_cxxopt "-Wno-dangling"
 
 # For 3rd party code: Disable warnings entirely.
 # They are not actionable and just create noise.

.github/workflows/github-actions-clang-tidy-bazel-post.yml

@@ -125,6 +125,40 @@ jobs:
         with:
           reviewdog_version: latest
 
+      - name: Dump reviewdog-visible env and event payload
+        # Gated on debug re-runs. Reviewdog emits "this is not PullRequest
+        # build" and posts nothing for fork PRs even though the synthesized
+        # pull_request payload is well-formed (verified locally against
+        # reviewdog v0.21.0). Suspect: step-level `env:` cannot override
+        # runner-protected GITHUB_EVENT_PATH / GITHUB_EVENT_NAME, so reviewdog
+        # reads the runner's workflow_run event payload instead of our synth.
+        # This step proves what reviewdog actually sees on the next debug
+        # re-run.
+        if: runner.debug == '1'
+        env:
+          GITHUB_EVENT_NAME: pull_request
+          GITHUB_EVENT_PATH: ${{ steps.event.outputs.event_path }}
+          GITHUB_SHA: ${{ steps.meta.outputs.head_sha }}
+          GITHUB_REPOSITORY: ${{ steps.meta.outputs.base_repo }}
+        run: |
+          echo "::group::GITHUB_* env visible to next step"
+          env | grep -E '^(GITHUB_|RUNNER_|REVIEWDOG_)' | sort
+          echo "::endgroup::"
+          echo "::group::Synth event file location and content"
+          echo "steps.event.outputs.event_path = ${{ steps.event.outputs.event_path }}"
+          echo "Effective GITHUB_EVENT_PATH    = ${GITHUB_EVENT_PATH}"
+          if [ -f "${GITHUB_EVENT_PATH}" ]; then
+            echo "--- file exists, content: ---"
+            cat "${GITHUB_EVENT_PATH}"
+          else
+            echo "::warning::GITHUB_EVENT_PATH file does not exist"
+          fi
+          echo "::endgroup::"
+          echo "::group::Synth file at literal path (should match above)"
+          SYNTH="${{ steps.event.outputs.event_path }}"
+          [ -f "${SYNTH}" ] && cat "${SYNTH}" || echo "missing"
+          echo "::endgroup::"
+
       - name: Run reviewdog
         env:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -133,7 +167,14 @@ jobs:
           GITHUB_SHA: ${{ steps.meta.outputs.head_sha }}
           GITHUB_REPOSITORY: ${{ steps.meta.outputs.base_repo }}
         run: |
+          # On debug re-runs add reviewdog's own -log-level=debug so the
+          # cienv detection trace is visible alongside the env dump above.
+          LOG_FLAGS=()
+          if [ "${RUNNER_DEBUG}" = "1" ]; then
+            LOG_FLAGS+=(-log-level=debug)
+          fi
           reviewdog \
+            "${LOG_FLAGS[@]}" \
             -efm="%E%f:%l:%c: error: %m" \
             -efm="%W%f:%l:%c: warning: %m" \
             -name="clang-tidy" \

.readthedocs.yaml

@@ -15,7 +15,7 @@ build:
     - libasound2
     - graphviz
   tools:
-    python: "3.7"
+    python: "3.10"
     nodejs: "16"
   jobs:
     post_install:

BUILD.bazel

@@ -187,6 +187,7 @@ OPENROAD_MAIN_DEPS = [
     "//src/utl",
     "//src/web",
     "@abseil-cpp//absl/base:no_destructor",
+    "@boost.dll",
     "@boost.stacktrace",
     "@rules_cc//cc/runfiles",  # sets BAZEL_CURRENT_REPOSITORY
     "@tcl_lang//:tcl",

CMakeLists.txt

@@ -74,6 +74,8 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
 
+set_property(DIRECTORY PROPERTY TEST_DISCOVERY_TIMEOUT 60)
+
 # Get version string in OPENROAD_VERSION
 if(NOT OPENROAD_VERSION)
   include(GetGitRevisionDescription)

MODULE.bazel

@@ -7,7 +7,20 @@ module(
 
 # --- Regular dependencies (propagated to downstream consumers via MVS) ---
 
-bazel_dep(name = "abc", version = "0.64-yosyshq.bcr.1")
+bazel_dep(name = "abc", version = "0.64-yosyshq.bcr.2")
+
+# Patch abc's non-readline prompt path to flush stdout and exit on EOF.
+# Without this, yosys's coprocess driver (which waits for the "abc NN> "
+# prompt over a pipe) deadlocks when abc is built with use_readline=false.
+# Drop this override once the fix is in a published BCR abc release.
+single_version_override(
+    module_name = "abc",
+    patch_strip = 1,
+    patches = [
+        "//bazel/abc-patches:0001-mainUtils-flush-prompt-and-handle-eof-without-readline.patch",
+    ],
+)
+
 bazel_dep(name = "abseil-cpp", version = "20260107.1")
 bazel_dep(name = "bazel_skylib", version = "1.7.1")
 bazel_dep(name = "coin-or-lemon", version = "1.3.1")
@@ -30,6 +43,7 @@ bazel_dep(name = "boost.bind", version = BOOST_VERSION)
 bazel_dep(name = "boost.config", version = BOOST_VERSION)
 bazel_dep(name = "boost.container", version = BOOST_VERSION)
 bazel_dep(name = "boost.container_hash", version = BOOST_VERSION)
+bazel_dep(name = "boost.dll", version = BOOST_VERSION)
 bazel_dep(name = "boost.format", version = BOOST_VERSION)
 bazel_dep(name = "boost.fusion", version = BOOST_VERSION)
 bazel_dep(name = "boost.geometry", version = BOOST_VERSION)

MODULE.bazel.lock

@@ -19,13 +19,16 @@ RUN install -m 0755 -d /etc/apt/keyrings \
 
 RUN apt-get -y update \
     && apt-get -y install --no-install-recommends \
+      bsdextrautils \
       build-essential \
       clang \
       containerd.io \
       docker-buildx-plugin \
       docker-ce \
       docker-ce-cli \
+      groff \
       openjdk-21-jre-headless \
+      pandoc \
       python3 \
       python3-yaml \
       time

bazel/Dockerfile

@@ -0,0 +1,62 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Matt Liberty <mliberty@precisioninno.com>
+Date: Fri, 30 May 2026 00:00:00 +0000
+Subject: [PATCH] mainUtils: match readline behavior when ABC_USE_READLINE is
+ undefined
+
+The non-readline branch of Abc_UtilsGetUsersInput has three behavioral
+gaps versus the readline branch that break callers driving abc as a
+coprocess over a pipe (e.g. yosys's techmap/abc.cc, which waits for the
+"abc NN> " prompt with the source command echoed back via
+read_until_abc_done()):
+
+  1. The prompt is written with fprintf() but never flushed. With stdout
+     fully buffered (pipe), the prompt never reaches the reader; the
+     reader waits for the prompt, abc waits in fgets(), deadlock.
+
+  2. There is no echo of the line read from stdin. readline() displays
+     each character as it is typed (and on a pipe, readline's stream
+     handling still emits the line + newline to its output). Without
+     that, yosys never sees the "abc NN> source ..." pattern it requires
+     to advance state.
+
+  3. EOF on stdin is silently ignored: fgets() returns NULL, the
+     function returns a stale Prompt buffer, and the caller loops. The
+     readline branch exits(0) when readline() returns NULL.
+
+Fix all three. Echo only when stdin is not a tty -- on a tty the kernel
+already echoes typed characters, and double-echo would be visible.
+
+Upstreaming to YosysHQ/abc and berkeley-abc/abc.
+
+Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
+---
+ src/base/main/mainUtils.c | 9 ++++++++-
+ 1 file changed, 8 insertions(+), 1 deletion(-)
+
+diff --git a/src/base/main/mainUtils.c b/src/base/main/mainUtils.c
+--- a/src/base/main/mainUtils.c
++++ b/src/base/main/mainUtils.c
+@@ -18,6 +18,8 @@
+
+ ***********************************************************************/
+
++#include <unistd.h>
++
+ #include "base/abc/abc.h"
+ #include "mainInt.h"
+
+@@ -91,7 +93,13 @@
+     {
+     char * pRetValue;
+     fprintf( pAbc->Out, "%s", Prompt );
++    fflush( pAbc->Out );
+     pRetValue = fgets( Prompt, 5000, stdin );
++    if ( pRetValue == NULL ) { exit(0); }
++    if ( !isatty( fileno(stdin) ) ) {
++        fputs( Prompt, pAbc->Out );
++        fflush( pAbc->Out );
++    }
+     return Prompt;
+     }
+ #endif

bazel/abc-patches/0001-mainUtils-flush-prompt-and-handle-eof-without-readline.patch

@@ -0,0 +1 @@
+exports_files(glob(["*.patch"]))