Merge branch 'master' into mpl-use-best-result

Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>

Author: AcKoucher

.bazelrc

@@ -24,8 +24,20 @@ build --copt "-Wall"               --host_copt "-Wall"
 build --copt "-Wextra"             --host_copt "-Wextra"
 
 # ... and disable the warnings we're not interested in.
-build --copt "-Wno-sign-compare"      --host_copt "-Wno-sign-compare"
-build --copt "-Wno-unused-parameter"  --host_copt "-Wno-unused-parameter"
+build --copt "-Wno-sign-compare"          --host_copt "-Wno-sign-compare"
+build --copt "-Wno-unused-parameter"      --host_copt "-Wno-unused-parameter"
+build --copt "-Wno-c++20-designator"      --host_copt "-Wno-c++20-designator"
+build --copt "-Wno-gcc-compat"            --host_copt "-Wno-gcc-compat"
+build --copt "-Wno-nullability-extension" --host_copt "-Wno-nullability-extension"
+
+# The warning acceptance bar in CI for PRs is set by -Werror of a specific
+# version of some chosen compiler. Disable warnings from other compilers until
+# they are fixed and under CI -Werror acceptance critera as there is nothing the
+# developers can(they can't be reproduced locally or in CI) or should do about
+# these warnings in code they are not working on.
+build --copt "-Wno-unused-private-field"  --host_copt "-Wno-unused-private-field"
+build --copt "-Wno-cast-function-type-mismatch"  --host_copt "-Wno-cast-function-type-mismatch"
+build --copt "-Wno-unused-but-set-variable"  --host_copt "-Wno-unused-but-set-variable"
 
 # For 3rd party code: Disable warnings entirely.
 # They are not actionable and just create noise.

.github/workflows/black.yaml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   lint:
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4

.github/workflows/github-actions-are-differences-found.yml

@@ -0,0 +1,20 @@
+name: Check that OK files are up to date
+
+on:
+  pull_request:
+
+jobs:
+  diffs:
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
+    steps:
+      - name: Check out repository code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Check ok files
+        run: |
+          set +e
+          grep --include="*.ok" -Rn "Differences found "
+          if [[ "$?" == "0" ]]; then
+            exit 1
+          fi

.github/workflows/github-actions-are-odb-files-generated.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   format:
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
     steps:
       - name: setup
         run: |

.github/workflows/github-actions-bazel-build.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   Build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
     steps:
       - name: Checkout code
         uses: actions/checkout@v4

.github/workflows/github-actions-clang-tidy-post.yml

@@ -9,7 +9,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
     steps:
       # Downloads the artifact uploaded by the lint action
       - name: 'Download artifact'

.github/workflows/github-actions-clang-tidy.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -20,7 +20,7 @@ jobs:
           build_dir: './build'
           cmake_command: cmake . -B build
           config_file: '.clang-tidy'
-          exclude: "*/codeGenerator/templates/*"
+          exclude: "*/codeGenerator/templates/*,*/third-party/*"
           split_workflow: true
           apt_packages: libomp-15-dev,libfl-dev
       - uses: The-OpenROAD-Project/clang-tidy-review/upload@master
@@ -33,4 +33,6 @@ jobs:
           echo "Ownership change attempt finished."
         shell: bash
       - if: steps.review.outputs.total_comments > 0
-        run: exit 1
+        run: |
+          echo "Pendinding review comments. Please resolve all comments before merging."
+          exit 1

.github/workflows/github-actions-cron-sync-fork-from-upstream-PII.yaml

@@ -16,7 +16,7 @@ on:
 jobs:
   Sync-Branch-From-Upstream:
     name: Automatic sync 'master' from The-OpenROAD-Project/OpenROAD
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
 
     # Only allow one action to run at a time.
     concurrency: sync-branch-from-upstream

.github/workflows/github-actions-cron-sync-fork-from-upstream.yml

@@ -16,7 +16,7 @@ on:
 jobs:
   Sync-Branch-From-Upstream:
     name: Automatic sync 'master' from The-OpenROAD-Project/OpenROAD
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
 
     # Only allow one action to run at a time.
     concurrency: sync-branch-from-upstream

.github/workflows/github-actions-format-on-push.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   format:
-    runs-on: ubuntu-latest
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
     steps:
       - name: Check out repository code
         uses: actions/checkout@v4