Merge remote-tracking branch 'origin/master' into TR-rules

Author: osamahammad21

docs/agents/coding.md

@@ -25,6 +25,21 @@
 ### Null Safety
 - Avoid adding too defensive null checks if the object cannot be null
 
+## Service Interfaces
+
+Abstract interfaces published through `utl::ServiceRegistry` use the
+`Service` suffix (e.g. `est::ParasiticsService`, `drt::PinAccessService`).
+Each interface lives in its owning module's public `include/<module>/`
+directory and is exposed as a small header-only Bazel target that
+consumers can depend on without pulling in the full implementation
+library. This keeps module dependency graphs acyclic and the decoupling
+visible at the build layer.
+
+Note that this is distinct from the `Abstract*` prefix used for
+graphics/visualization mock-swappable classes (e.g.
+`AbstractSteinerRenderer`); those are inherited for test/headless modes
+rather than looked up through a registry.
+
 ## Common Coding Mistakes
 
 ### OpenROAD Message ID Duplicate Checker

etc/Dockerfile.claude

@@ -3,7 +3,9 @@
 #
 # Usage: see claude.sh at the repo root.
 
-ARG fromImage=openroad/ubuntu22.04-dev:latest
+# Ubuntu 24.04 provides glibc 2.39, required by the LLVM 20 toolchain
+# that Bazel downloads (needs __isoc23_* symbols from glibc >= 2.38).
+ARG fromImage=openroad/ubuntu24.04-dev:latest
 
 FROM ${fromImage}
 

include/ord/OpenRoad.hh

@@ -108,7 +108,7 @@ class ICeWall;
 
 namespace utl {
 class Logger;
-class CallBackHandler;
+class ServiceRegistry;
 }  // namespace utl
 
 namespace dst {
@@ -151,7 +151,7 @@ class OpenRoad
 
   Tcl_Interp* tclInterp() { return tcl_interp_; }
   utl::Logger* getLogger() { return logger_; }
-  utl::CallBackHandler* getCallBackHandler() { return callback_handler_; }
+  utl::ServiceRegistry* getServiceRegistry() { return service_registry_; }
   odb::dbDatabase* getDb() { return db_; }
   sta::dbSta* getSta() { return sta_; }
   sta::dbNetwork* getDbNetwork();
@@ -288,7 +288,7 @@ class OpenRoad
   dft::Dft* dft_ = nullptr;
   est::EstimateParasitics* estimate_parasitics_ = nullptr;
   web::WebServer* web_server_ = nullptr;
-  utl::CallBackHandler* callback_handler_ = nullptr;
+  utl::ServiceRegistry* service_registry_ = nullptr;
 
   int threads_ = 1;
 

packaging/BUILD.bazel

@@ -8,6 +8,7 @@ sh_binary(
     name = "install",
     srcs = ["//bazel:install.sh"],
     data = [":tarfile"],
+    visibility = ["//visibility:public"],
 )
 
 pkg_tar(

src/OpenRoad.cc

@@ -83,11 +83,11 @@
 #include "tap/MakeTapcell.h"
 #include "tap/tapcell.h"
 #include "upf/MakeUpf.h"
-#include "utl/CallBackHandler.h"
 #include "utl/Logger.h"
 #include "utl/MakeLogger.h"
 #include "utl/Progress.h"
 #include "utl/ScopedTemporaryFile.h"
+#include "utl/ServiceRegistry.h"
 #include "utl/decode.h"
 #include "web/MakeWeb.h"
 #include "web/web.h"
@@ -150,7 +150,7 @@ OpenRoad::~OpenRoad()
   delete web_server_;
   delete logger_;
   delete verilog_reader_;
-  delete callback_handler_;
+  delete service_registry_;
 }
 
 sta::dbNetwork* OpenRoad::getDbNetwork()
@@ -195,7 +195,7 @@ void OpenRoad::init(Tcl_Interp* tcl_interp,
   // Make components.
   utl::Progress::setBatchMode(batch_mode);
   logger_ = new utl::Logger(log_filename, metrics_filename);
-  callback_handler_ = new utl::CallBackHandler(logger_);
+  service_registry_ = new utl::ServiceRegistry(logger_);
   db_->setLogger(logger_);
   sta_ = new sta::dbSta(tcl_interp, db_, logger_);
   verilog_network_ = new dbVerilogNetwork(sta_);
@@ -204,7 +204,7 @@ void OpenRoad::init(Tcl_Interp* tcl_interp,
   antenna_checker_ = new ant::AntennaChecker(db_, logger_);
   opendp_ = new dpl::Opendp(db_, logger_);
   global_router_ = new grt::GlobalRouter(logger_,
-                                         callback_handler_,
+                                         service_registry_,
                                          stt_builder_,
                                          db_,
                                          sta_,
@@ -213,7 +213,7 @@ void OpenRoad::init(Tcl_Interp* tcl_interp,
   grt::initGui(global_router_, db_, logger_);
 
   estimate_parasitics_ = new est::EstimateParasitics(
-      logger_, callback_handler_, db_, sta_, stt_builder_, global_router_);
+      logger_, service_registry_, db_, sta_, stt_builder_, global_router_);
   est::initGui(estimate_parasitics_);
 
   resizer_ = new rsz::Resizer(logger_,
@@ -240,7 +240,7 @@ void OpenRoad::init(Tcl_Interp* tcl_interp,
   extractor_ = new rcx::Ext(db_, logger_, getVersion());
   distributer_ = new dst::Distributed(logger_);
   detailed_router_ = new drt::TritonRoute(
-      db_, logger_, callback_handler_, distributer_, stt_builder_);
+      db_, logger_, service_registry_, distributer_, stt_builder_);
   drt::initGui(detailed_router_);
 
   replace_ = new gpl::Replace(db_, sta_, resizer_, global_router_, logger_);

src/dpl/include/dpl/Opendp.h

@@ -238,6 +238,7 @@ class Opendp
                    GridX x_end,
                    GridY y_end) const;
   bool checkMasterSym(unsigned masterSym, unsigned cellOri) const;
+  bool checkRowPowerCompatible(const Node* cell, GridY y) const;
   bool ripUpAndReplace(Node* cell);
   bool diamondMove(Node* cell);
   bool diamondMove(Node* cell, const GridPt& grid_pt);

src/dpl/src/CheckPlacement.cpp

@@ -350,7 +350,8 @@ bool Opendp::checkInRows(const Node& cell) const
       }
     }
   }
-  return true;
+  return !cell.getMaster()->isMultiRow()
+         || checkRowPowerCompatible(&cell, grid_rect.ylo);
 }
 
 // Return the cell this cell overlaps.

src/dpl/src/Place.cpp

@@ -27,6 +27,7 @@
 #include "infrastructure/Grid.h"
 #include "infrastructure/Objects.h"
 #include "infrastructure/Padding.h"
+#include "infrastructure/architecture.h"
 #include "infrastructure/network.h"
 #include "odb/db.h"
 #include "odb/dbTransform.h"
@@ -1089,9 +1090,26 @@ bool Opendp::checkPixels(const Node* cell,
     return false;
   }
 
+  // For multi-row cells, the bottom-row site/orient check above only covers
+  // the bottom row; it doesn't ensure the master's power pin stack lines up
+  // with the PDN rail stack across the span.  Reject wrong-parity landings.
+  if (cell->getMaster()->isMultiRow() && !checkRowPowerCompatible(cell, y)) {
+    return false;
+  }
+
   return drc_engine_->checkDRC(cell, x, y, orient);
 }
 
+bool Opendp::checkRowPowerCompatible(const Node* cell, const GridY y) const
+{
+  const int row_idx = arch_->find_closest_row(grid_->gridYToDbu(y));
+  if (row_idx >= arch_->getNumRows()) {
+    return false;
+  }
+  bool flip = false;
+  return arch_->powerCompatible(cell, arch_->getRow(row_idx), flip);
+}
+
 bool Opendp::checkMasterSym(unsigned masterSym, unsigned cellOri) const
 {
   using odb::dbOrientType;

src/dpl/src/dbToOpendp.cpp

@@ -6,8 +6,10 @@
 #include <limits>
 #include <map>
 #include <memory>
+#include <optional>
 #include <string>
 #include <unordered_set>
+#include <utility>
 #include <vector>
 
 #include "PlacementDRC.h"
@@ -111,6 +113,59 @@ bool bboxIntersectsOuterShell(const Rect& bbox,
   });
 }
 
+// Look at single-row CORE masters and return a canonical R0-row (topPwr,
+// botPwr). Requires top != bot so the convention is unambiguous;
+// symmetric-power cells cannot anchor the convention.  Returns (UNK, UNK) if
+// none found.
+std::pair<int, int> inferR0RowPower(const Network* network,
+                                    const Grid* grid,
+                                    odb::dbBlock* block)
+{
+  for (odb::dbInst* inst : block->getInsts()) {
+    odb::dbMaster* db_master = inst->getMaster();
+    if (db_master->getType() != odb::dbMasterType::CORE) {
+      continue;
+    }
+    if (grid->isMultiHeight(db_master)) {
+      continue;
+    }
+    const Master* dpl_master
+        = const_cast<Network*>(network)->getMaster(db_master);
+    if (dpl_master == nullptr) {
+      continue;
+    }
+    const int bot = dpl_master->getBottomPowerType();
+    const int top = dpl_master->getTopPowerType();
+    if (bot != Architecture::Row::Power_UNK
+        && top != Architecture::Row::Power_UNK && bot != top) {
+      return {top, bot};
+    }
+  }
+  return {Architecture::Row::Power_UNK, Architecture::Row::Power_UNK};
+}
+
+// Whether the orientation flips the master's Y axis (swapping top and bottom
+// power rails).  Only the axis-aligned orientations are expected for standard
+// cell rows; rotations return nullopt so row power stays unknown.
+std::optional<bool> orientFlipsY(const odb::dbOrientType& orient)
+{
+  using odb::dbOrientType;
+  switch (orient.getValue()) {
+    case dbOrientType::MX:
+    case dbOrientType::R180:
+      return true;
+    case dbOrientType::R0:
+    case dbOrientType::MY:
+      return false;
+    case dbOrientType::R90:
+    case dbOrientType::R270:
+    case dbOrientType::MXR90:
+    case dbOrientType::MYR90:
+      return std::nullopt;
+  }
+  return std::nullopt;
+}
+
 }  // namespace
 
 void Opendp::importDb()
@@ -292,7 +347,8 @@ void Opendp::createArchitecture()
     archRow->setSiteWidth(DbuX{site->getWidth()});
     archRow->setHeight(DbuY{site->getHeight()});
 
-    // Set defaults.  Top and bottom power is set below.
+    // Start with UNK; resolved after all rows are created using an inferred
+    // R0 row convention.
     archRow->setBottomPower(Architecture::Row::Power_UNK);
     archRow->setTopPower(Architecture::Row::Power_UNK);
 
@@ -356,6 +412,29 @@ void Opendp::createArchitecture()
   arch_->setPadding(padding_.get());
   arch_->setSiteWidth(grid_->getSiteWidth());
 
+  // Populate each row's top/bottom power rail from an inferred R0 convention.
+  // Without this, row power stays Power_UNK and Architecture::powerCompatible
+  // degenerates to "always true", letting multi-row cells land on wrong-parity
+  // rows (VDD pin on VSS stripe, etc.).
+  const auto [ref_r0_top, ref_r0_bot]
+      = inferR0RowPower(network_.get(), grid_.get(), block);
+  if (ref_r0_bot != Architecture::Row::Power_UNK) {
+    for (int r = 0; r < arch_->getNumRows(); r++) {
+      Architecture::Row* archRow = arch_->getRow(r);
+      const auto flipped = orientFlipsY(archRow->getOrient());
+      if (!flipped.has_value()) {
+        continue;  // Rotation — leave as UNK.
+      }
+      if (*flipped) {
+        archRow->setBottomPower(ref_r0_top);
+        archRow->setTopPower(ref_r0_bot);
+      } else {
+        archRow->setBottomPower(ref_r0_bot);
+        archRow->setTopPower(ref_r0_top);
+      }
+    }
+  }
+
   arch_->postProcess(network_.get());
 }
 

src/dpl/test/CMakeLists.txt

@@ -47,6 +47,7 @@ or_integration_tests(
     mirror2
     mirror3
     multi_height_one_site_gap_disallow
+    multi_height_power_align
     multi_height_rows
     obstruction1
     obstruction2