detailed_placement creates unroutable placement for centered floorplan

[stefanottili]

Describe the bug

revisiting #5557 shows that gpl/rudy work correctly for a centered floorplan.

It's the detailed_placement that messes up the stdcells and creates an unroutable placement.

Expected Behavior

detailed_placement should be able to handle any DIEAREA ( x1 y1 ) ( x2 y2 ), not just x1 = 0, y1 = 0, x2 > 0 y2 > 0

Environment

MacOS M1 homebrew OpenROAD v2.0-18955-g3332c5ee6

To Reproduce

#5557 has a tar file with lef/def/or command file.

Relevant log output

[NesterovSolve] Finished with Overflow: 0.099042
Placement Analysis
---------------------------------
total displacement    3613512.4 u
average displacement      110.8 u
max displacement          736.0 u
original HPWL         1091240.1 u
legalized HPWL        4943157.6 u
delta HPWL                  353 %

Screenshots

No response

Additional Context

No response

[stefanottili]

Same netlist using a first quadrant floorplan works as expected.

Placement Analysis
---------------------------------
total displacement     107598.5 u
average displacement        3.3 u
max displacement           15.1 u
original HPWL         1091253.2 u
legalized HPWL        1194890.2 u
delta HPWL                    9 %

[stefanottili]

detailed_placement worked as of filing #5557 in Aug 15 2024.
bisecting is tricky since older versions don’t compile with boost 1.87

[maliberty]

Don't bother bisecting as there were substantial changes for hybrid rows. This has no priority to fix

[stefanottili]

It's stale because it has not been addressed, please leave it open.
dpl fails to legalize the ICCAD 2004 testcases, gpl/grt/drt/gui work with a centered floorplan.
No priority, but a bug nevertheless.

[stefanottili]

@gudeh
#10064 dpl: introduce new legalization algorithm - negotiation based

fixes the case of "floorplan left,bottom not 0,0" issue of the ICCAD04 testcases.

Is this new dpl algorithm going to be the new default any time soon ?

Coredump with 'global_placement_debug -generate_images', separate issue ...

[maliberty]

The plan is to make it the default and eventually to retire the current algorithm.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the Stale label or comment to keep it open.