Warning about different compile db: check multiple directories.#10067
Merged
maliberty merged 1 commit intoApr 7, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the bazel-make-compilation-db.sh script to check for existing compile_commands.json files in both the root and build/ directories, warning the user of potential interference with compile_flags.txt. Feedback suggests improving the robustness of the warning message by using the %s format specifier in printf to handle special characters in file paths and redirecting the output to stderr to ensure visibility.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
When creating a compilation db for bazel, but there is still another compile db from cmake (e.g. from some previous build with cmake), then tools might not choose the intended one. There was a warning already emitted for that case, but only for the toplevel directory not if it was in build/. Make this for both of these. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260407-warn-compdb
branch
from
13914b6 to
d206b37
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a compilation db for bazel, but there is still another compile db from cmake (e.g. from some previous build with cmake), then tools might not choose the intended one.
There was a warning already emitted for that case, but only for the toplevel directory not if it was in build/. Make this for both of these.