DRT: Handle unconnected pins when initializing maze costs#10079
Merged
maliberty merged 2 commits intoApr 7, 2026
Merged
Conversation
… connected to a net Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
maliberty
approved these changes
Apr 7, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the FlexDRWorker::initMazeCost_fixedObj function by removing null checks for nets when mapping boundary and instance terms. It also includes extensive updates to test expectation files (.defok) for several routing tests, reflecting modifications in the generated routing paths and via configurations. I have no feedback to provide.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
already run through a full CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In PR #9984, a small change was made to initializing terms costs that led to ignore costing for unconnected pins. This pushed the detailed router to route over those nets without realizing them. However,
FlexGCmarks such routing later as violations because it can recognize all shapes regardless of connection. This led to overall suffering in the detailed router convergance which could be observed in ispd18_test10.Type of Change
Impact
This should lead to a faster convergence and fix the CI timeout for ispd18_test10
Verification
./etc/Build.sh).Related Issues
#10010