changed 3 RSZ errors to warnings#10081
Merged
maliberty merged 2 commits intoApr 8, 2026
Merged
Conversation
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the buffering logic in Rebuffer.cc by replacing critical log messages with more descriptive warnings when no valid buffering solutions are found for a net. It also introduces a null return when top-level buffering options are empty and removes a fallback assignment to previous options during wire stepping. I have no feedback to provide as there were no review comments to evaluate.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
@povik, Martin, FYI. |
maliberty
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed three resizer errors to warnings
Type of Change
Impact
This allows the global placer resizing optimization to continue even when buffering fails on some nets
Verification
./etc/Build.sh).Related Issues
[Link issues here]