Skip to content

ord: Set Tech name when using Tech API programmatically#10090

Merged
maliberty merged 4 commits into
The-OpenROAD-Project:masterfrom
mikesinouye:tech
Apr 9, 2026
Merged

ord: Set Tech name when using Tech API programmatically#10090
maliberty merged 4 commits into
The-OpenROAD-Project:masterfrom
mikesinouye:tech

Conversation

@mikesinouye

@mikesinouye mikesinouye commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

When using the Tech API programmatically, the tech lef name will not be set when creating a tech. This change aligns the API with the tcl proc, which passes the tech name when creating the tech. Extend the existing Tech API test to verify this.

set tech_name ""
set lib_name [file rootname [file tail $filename]]
if { [info exists keys(-tech_name)] } {
set tech_name $keys(-tech_name)
} elseif { $make_tech } {
set tech_name $lib_name
}
ord::read_lef_cmd $filename $lib_name $tech_name $make_tech $make_lib

Type of Change

  • Bug fix

Impact

Tech name can now be set when using Tech API.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Tech::readLef function in src/Tech.cc to conditionally assign a technology name based on the make_tech flag, ensuring the library name is used when a technology is being created. A corresponding assertion was added to the timing_report_api.py test to verify that the technology name is correctly initialized and not empty. I have no feedback to provide.

@maliberty maliberty merged commit 55f3a06 into The-OpenROAD-Project:master Apr 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants