Skip to content

ord: Set Tech name when using Tech API programmatically #10090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 4 commits into from
Apr 9, 2026
Merged

ord: Set Tech name when using Tech API programmatically #10090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66814d6
Only pass a tech_name if a tech is being created.
mikesinouye Apr 8, 2026
16e1b0f
Add test to verify tech has a name
mikesinouye Apr 8, 2026
aa0f711
Revert timing_api.py
mikesinouye Apr 8, 2026
cff5d54
Move test to timing_report_api.py
mikesinouye Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Tech.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ void Tech::readLef(const std::string& file_name)
lib_name.erase(lib_name.begin() + dot_pos, lib_name.end());
}

const char* tech_name = make_tech ? lib_name.c_str() : "";
app_->readLef(
file_name.c_str(), lib_name.c_str(), "", make_tech, make_library);
file_name.c_str(), lib_name.c_str(), tech_name, make_tech, make_library);
}

void Tech::readLiberty(const std::string& file_name)
Expand Down
2 changes: 2 additions & 0 deletions test/timing_report_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
tech.readLef("Nangate45/Nangate45_tech.lef")
tech.readLef("Nangate45/Nangate45_stdcell.lef")

assert tech.getTech().getName() != ""

design = Design(tech)
design.readDef("gcd_nangate45.def")
design.evalTclString("read_sdc timing_api_3.sdc")
Expand Down
Loading