Bump Boost 1.89.0.bcr.2 → 1.90.0.bcr.1#10105
Conversation
Updates all 27 boost module deps via the BOOST_VERSION constant. Boost 1.89→1.90 is source-compatible; CMake build (1.89.0) should continue working. The boost.context parse_headers patch may need rebasing if it doesn't apply cleanly to 1.90. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the BOOST_VERSION constant in MODULE.bazel from 1.89.0 to 1.90.0. Feedback was provided regarding the importance of maintaining version parity between the Bazel and CMake build systems to avoid potential binary compatibility issues or build failures.
| bazel_dep(name = "swig", version = "4.3.0.bcr.2") | ||
|
|
||
| BOOST_VERSION = "1.89.0.bcr.2" | ||
| BOOST_VERSION = "1.90.0.bcr.1" |
There was a problem hiding this comment.
The pull request description indicates that the CMake build remains at Boost 1.89.0. It is highly recommended to keep the Boost version consistent across all build systems (Bazel and CMake) to avoid potential binary compatibility issues or build failures if code changes start utilizing features specific to Boost 1.90.0.
|
out of sight out of mind for now. seems to work. |
1 participant
Updates all 27 boost module deps via the BOOST_VERSION constant. Boost 1.89→1.90 is source-compatible; CMake build (1.89.0) should continue working. The boost.context parse_headers patch may need rebasing if it doesn't apply cleanly to 1.90.