bazel: make toolchains_llvm a dev_dependency#10110
Merged
maliberty merged 1 commit intoApr 11, 2026
Merged
Conversation
The bazel_dep was non-dev, forcing downstream Bazel consumers to inherit OpenROAD's pinned LLVM toolchain. This conflicts when consumers configure their own C++ toolchain. The extension and toolchain registration were already dev_dependency. Making the bazel_dep dev_dependency too keeps it consistent and invisible to downstream modules. The llvm_prebuilt build_file reference works because dev deps are still resolved for the declaring module's own build. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Collaborator
Author
|
@hzeller Thoughts? |
maliberty
approved these changes
Apr 11, 2026
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
Looks good. |
Collaborator
Author
|
@maliberty ugh. module.bazel.lock needs update. Can you fix it? It's going to conflict with some PR going in before this one if I do it. @hzeller can't even do that reliably locally... I understood. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
maliberty
merged commit 66c2b5e
into
The-OpenROAD-Project:master
15 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bazel_dep was non-dev, forcing downstream Bazel consumers to inherit OpenROAD's pinned LLVM toolchain. This conflicts when consumers configure their own C++ toolchain.
The extension and toolchain registration were already dev_dependency. Making the bazel_dep dev_dependency too keeps it consistent and invisible to downstream modules. The llvm_prebuilt build_file reference works because dev deps are still resolved for the declaring module's own build.