-
Notifications
You must be signed in to change notification settings - Fork 946
odb: fix segfault on invalid path in read_3dbx #10119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oksaumya
wants to merge
12
commits into
The-OpenROAD-Project:master
Choose a base branch
from
oksaumya:fix/odb-segfault-read-3dbx-invalid-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9ebaa8a
odb: fix segfault on invalid path in read_3dbx
oksaumya f8a4b1d
odb: address copilot reviewer feedback on read_3dbx segfault fix
oksaumya 01e13df
odb: fix segfault when DEF file referenced in 3DBV is missing
oksaumya 751493e
odb: address maintainer feedback on read_3dbx segfault fix
oksaumya 1164291
odb: address feedback on read_3dbx segfault fix
oksaumya 411554d
odb: address feedback on read_3dbx segfault fix
oksaumya cdc35a3
odb: address feedback on read_3dbx segfault fix
oksaumya d10a359
odb: fix tclfmt formatting in read_3dbx-fail.tcl
oksaumya 2925c6a
odb: move read_3dbx-fail to PASSFAIL_TESTS in Bazel BUILD
oksaumya 8606ca9
odb: move read_3dbx-fail to PASSFAIL_TESTS in CMake
oksaumya 4ec433e
Merge remote-tracking branch 'upstream/master' into fix/odb-segfault-…
oksaumya 805c987
ci: retrigger after GitHub 502 on boost.proto download
oksaumya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| Header: | ||
| version: "1.0" | ||
| unit: "micron" | ||
| precision: 2000 | ||
| include: | ||
| - nonexistent_include.3dbv | ||
|
|
||
| Design: | ||
| name: "TestDesign" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Caught expected error: main file not found | ||
| Caught expected error: include file not found | ||
| pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| source "helpers.tcl" | ||
|
|
||
| # Test that read_3dbx gives a proper error for a non-existent file | ||
| # rather than segfaulting (regression test for issue #10082) | ||
|
|
||
| # Test 1: Main file does not exist | ||
| if { [catch {read_3dbx "nonexistent_file.3dbx"} err_msg] } { | ||
| puts "Caught expected error: main file not found" | ||
| } else { | ||
| puts "FAIL: Expected an error for non-existent main file" | ||
| exit 1 | ||
| } | ||
|
|
||
| # Test 2: Main file exists but references a non-existent include | ||
| if { [catch {read_3dbx "data/fail.3dbx"} err_msg] } { | ||
| puts "Caught expected error: include file not found" | ||
| } else { | ||
| puts "FAIL: Expected an error for non-existent include file" | ||
| exit 1 | ||
| } | ||
|
oksaumya marked this conversation as resolved.
Outdated
|
||
|
|
||
| puts "pass" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.