mpl: make default halo live in HierRTLMP#10133
Merged
maliberty merged 1 commit intoApr 14, 2026
Merged
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Contributor
Author
|
@joaomai FYI. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the management of default halos by moving the default_halo member from the PhysicalHierarchy struct into the ClusteringEngine and HierRTLMP classes. The setHalos method in ClusteringEngine has been updated to receive the default halo as an argument, and all internal usages have been updated to reference the new class members. I have no feedback to provide.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default halo is not stored inside the tree struct anymore.
Type of Change
Impact
The halo information will be available outside the scope of HierRTLMP flow which will allows us to have a separate pass only for blockage generation.
Verification
./etc/Build.sh).