Skip to content

ci: add post-merge auto-format GitHub Actions workflow#10136

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:gha-post-merge-fixing
Apr 15, 2026
Merged

ci: add post-merge auto-format GitHub Actions workflow#10136
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:gha-post-merge-fixing

Conversation

@openroad-ci

Copy link
Copy Markdown
Member

Summary

Run clang-format, buildifier, black, and tclfmt on files changed in each push to master, committing any fixes automatically.

Type of Change

  • New feature

Impact

A step towards automating these steps

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Run clang-format, buildifier, black, and tclfmt on files changed
in each push to master, committing any fixes automatically.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@maliberty maliberty requested a review from vvbandeira April 15, 2026 00:06
@maliberty maliberty requested a review from oharboe April 15, 2026 00:06
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@oharboe oharboe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌

use bazel to do this so it can be replicated locally, I think it will save work and frustrations nd be more robust. bazelisk run //:fix_lint is all that should happen in this just + commit

also, bazel minimizes docker config github ci hell. just test and minimize config required locally and you are done. no docker image hell.

@nekronos Thoughts? You are the expert on implementation here

@maliberty

Copy link
Copy Markdown
Member

fix_lint only does tclfmt/tclint afaik, while this also does clang-format, black, buildifier, and lock file updating.

@oharboe

oharboe commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

fix_lint only does tclfmt/tclint afaik, while this also does clang-format, black, buildifier, and lock file updating.

move all those into fix_lint

@nekronos

Copy link
Copy Markdown
Contributor

😌

use bazel to do this so it can be replicated locally, I think it will save work and frustrations nd be more robust. bazelisk run //:fix_lint is all that should happen in this just + commit

Yes, best to make it reproducible across CI/local

also, bazel minimizes docker config github ci hell. just test and minimize config required locally and you are done. no docker image hell.

Also a benefit of making available as a bazel target

@nekronos Thoughts? You are the expert on implementation here

@maliberty

Copy link
Copy Markdown
Member

When all those things are in bazel I'm fine to convert but I think this can still be merged as is until then.

@oharboe

oharboe commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

When all those things are in bazel I'm fine to convert but I think this can still be merged as is until then.

👍

@maliberty maliberty merged commit 92fbeb5 into The-OpenROAD-Project:master Apr 15, 2026
17 checks passed
@maliberty maliberty deleted the gha-post-merge-fixing branch April 15, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants