Skip to content

mpl: add new command set_macro_default_halo#10142

Merged
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
AcKoucher:mpl-set-macro-default-halos
Apr 16, 2026
Merged

mpl: add new command set_macro_default_halo#10142
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
AcKoucher:mpl-set-macro-default-halos

Conversation

@AcKoucher

@AcKoucher AcKoucher commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Apart from the title:

  • Add 2 tests for the new command (2 - width, height - and 4 - L, B, R, T - halo arguments);
  • Update existing tests to not use halos at all.
  • Add deprecated warning for -halo_width and -halo_height.

Type of Change

  • New feature

Impact

Setting a default halo is now possible without necessarily having to run MPL. That way, the blockage generation pass that is being developed will not rely on running MPL to cache the default halo data.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the macro halo configuration by replacing the global -halo_width and -halo_height arguments in rtl_macro_placer with a new, more flexible set_macro_default_halo command. This change allows for both uniform and per-side halo definitions. The reviewer suggested improving the Tcl command argument description for better user guidance.

Comment thread src/mpl/src/mpl.tcl
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@AcKoucher

AcKoucher commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

Checks failures are due to bazel-orfs not containing the script changes on The-OpenROAD-Project/OpenROAD-flow-scripts#4149.

Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@AcKoucher AcKoucher changed the title mpl: remove -halo arguments and add new command set_macro_default_halo mpl: add new command set_macro_default_halo Apr 15, 2026
@AcKoucher AcKoucher requested a review from maliberty April 16, 2026 13:35
@AcKoucher AcKoucher marked this pull request as draft April 16, 2026 14:57
@AcKoucher AcKoucher marked this pull request as ready for review April 16, 2026 14:59
@maliberty maliberty merged commit 96a642d into The-OpenROAD-Project:master Apr 16, 2026
16 checks passed
@AcKoucher AcKoucher deleted the mpl-set-macro-default-halos branch April 16, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants