mpl: add new command set_macro_default_halo#10142
Merged
maliberty merged 2 commits intoApr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the macro halo configuration by replacing the global -halo_width and -halo_height arguments in rtl_macro_placer with a new, more flexible set_macro_default_halo command. This change allows for both uniform and per-side halo definitions. The reviewer suggested improving the Tcl command argument description for better user guidance.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
409beb9 to
20d3b98
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
Checks failures are due to bazel-orfs not containing the script changes on The-OpenROAD-Project/OpenROAD-flow-scripts#4149. |
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apart from the title:
-halo_widthand-halo_height.Type of Change
Impact
Setting a default halo is now possible without necessarily having to run MPL. That way, the blockage generation pass that is being developed will not rely on running MPL to cache the default halo data.
Verification
./etc/Build.sh).