DRT: fix RouterConfiguration Serialization#10143
Merged
maliberty merged 2 commits intoApr 16, 2026
Merged
Conversation
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of unidirectional layers by storing layer names in a std::setstd::string instead of pointers and changes drcReportIterStep from an optional to a default-initialized integer. Additionally, it updates the serialization logic for RouterConfiguration to include several previously omitted fields. Feedback was provided regarding the lack of validation for layer names when populating the unidirectional layers set.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix RouterConfiguration Serialization
Type of Change
Impact
No impact.
Verification
./etc/Build.sh).