Driver vertex level cache#10155
Merged
maliberty merged 6 commits intoApr 16, 2026
Merged
Conversation
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Resizer and its associated modules to eliminate manual management of vertex ordering. By removing internal caching and invalidation logic for driver vertices, the code now directly utilizes the sta engine's levelized vertex retrieval. Feedback indicates a potential logic error in RepairDesign.cc where progress reporting might become inaccurate due to cumulative iteration counts being compared against a per-pass vertex count. Additionally, it is recommended to use size_t for vertex counts to prevent narrowing conversions.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is part 2 of 2 for OpenSTA API change.
Resizer optimization now uses new OpenSTA APIs for driver vertex level cache.
This simplifies the code and improves robustness against future changes.
Type of Change
Impact
There is no QoR or runtime impact.
This should eliminate fatals due to stale vertex level cache in the future.
Verification
./etc/Build.sh).Related Issues
(#9851)