fix: null dereference before guard in repairEndHold#10158
Merged
maliberty merged 1 commit intoApr 16, 2026
Conversation
suhr25
force-pushed
the
fix/repair-hold-null-path
branch
from
dace99a to
7b04b1f
Compare
end_path->mode() was called before the if (end_path) null check, making the guard unreachable on a null return. Move the mode extraction inside the guard where it is actually used. Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
suhr25
force-pushed
the
fix/repair-hold-null-path
branch
from
7b04b1f to
2dae83c
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 16, 2026
maliberty
left a comment
maliberty
left a comment
Member
There was a problem hiding this comment.
I guess you have no paths at all?
maliberty
merged commit 6e984d0
into
The-OpenROAD-Project:master
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a crash in
RepairHold::repairEndHold()caused by usingend_pathbefore checking if it’s null. The issue is insrc/rsz/src/RepairHold.cc, and the fix simply makes the existing guard actually work.FIX
Before:
After:
VERIFICATION
Run
repair_holdon a design with missing/partial constraints. Before, this could segfault when no path exists. After the fix, it skips safely and completes without crashing.